Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pypy7.3.15 #116

Merged
merged 18 commits into from
Jan 30, 2024
Merged

Pypy7.3.15 #116

merged 18 commits into from
Jan 30, 2024

Conversation

mattip
Copy link
Contributor

@mattip mattip commented Jan 29, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Closes #115 (once the ppc64le build is uploaded manually)

Updates PyPy to 7.3.15, which replaces #114. Also creates a python3.10 package for pypy, which solves conda-forge/pypy-meta-feedstock#32. This is a convenience, and is not meant to trigger a migration. People who want to use python3.10 with PyPy will need to install packages from pip.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

IIUC, pypy3.10 is blocked on (at least) pypy/pypy#4883? I saw the discussion in conda-forge/pypy-meta-feedstock#32 just now (wasn't following that repo), and I agree it would be good to have 3.10 even if we don't end up migrating for it1

Footnotes

  1. though I guess I'd be tempted to migrate nevertheless, because - modulo some issues where testing got tightened (e.g. pandas) - it'd be almost "for free" to catch up with the "feedstock coverage" of the pypy3.9 migration.

@mattip
Copy link
Contributor Author

mattip commented Jan 30, 2024

it'd be almost "for free" to catch up

Nothing is ever for free. With only 1385 packages migrated and nearly 400 packages still in transit, the pypy38/39 migration is far from finished. I thought the 3.10 package would JustWork, and it seems there are problems, like pypy/pypy#4883

@mattip
Copy link
Contributor Author

mattip commented Jan 30, 2024

Reminder: once this gets merged, I should use this workflow to create and upload ppc64le and aarch64 packages

@h-vetinari
Copy link
Member

Nothing is ever for free. With only 1385 packages migrated and nearly 400 packages still in transit [...]

My point was not about those in transit, but those already built for pypy3.9. Based on previous migrations and pypy's focus on compatibility, I expect the vast majority of feedstocks already being built for pypy3.9 to build essentially unchanged for pypy3.10 as well. That's what I meant by "catching up with the feedstock coverage".

If indeed there is a lot of breakage by going from 3.9 and 3.10 (like apparently pypy/pypy#4883), then that argument is moot, but I think that should be rare. In any case, the migration discussion is completely separate, and just building 3.10 already would be cool.

@mattip mattip merged commit d57c623 into conda-forge:main Jan 30, 2024
5 checks passed
@mattip
Copy link
Contributor Author

mattip commented Jan 31, 2024

I uploaded the aarch64 and ppc64le packages to https://anaconda.org/mattip/pypy3.9/files and marked them as "copy". Here are the logs

aarch64-log.txt
ppc64le-log.txt

@isuruf could you check the logs and copy the packages to the proper place?

@h-vetinari
Copy link
Member

Here are the logs

I just had a look, and I see that there are several builds in those logs (for aarch)

BUILD START: ['pypy3.8-7.3.11-hca25ad7_0.tar.bz2']
BUILD START: ['pypy3.8-7.3.11-hf9a8208_0.tar.bz2']
BUILD START: ['pypy3.9-7.3.11-h3253541_0.tar.bz2']
BUILD START: ['pypy3.9-7.3.11-h21982c9_0.tar.bz2']
BUILD START: ['pypy3.9-7.3.15-h63376dd_0.tar.bz2']

The last one matches what you uploaded, so I assume that's the correct log, but next time please only copy the logs for the respective build. The build logs itself look fine, though there's a bunch of noise coming from - pypy3 -m test.test_ssl (including stacktraces), but I'm assuming that's part of the test suite, and that pypy would exit with a non-zero exit code if the tests fail?

@mattip
Copy link
Contributor Author

mattip commented Feb 2, 2024

I see that there are several builds in those logs

Sorry.

I'm assuming that's part of the test suite, and that pypy would exit with a non-zero exit code

Yes. That can be confirmed in the py3.10 runs, which fail that test and is why I excluded 3.10 from this PR.

@h-vetinari
Copy link
Member

Copied!

>set "LABEL=copy"
>set "DELEGATE=mattip"
>set "PACKAGE_VERSION=7.3.15"
>anaconda copy --from-label %LABEL% --to-label main --to-owner conda-forge %DELEGATE%/pypy3.9/%PACKAGE_VERSION%
Using Anaconda API: https://api.anaconda.org
Copied file: linux-aarch64/pypy3.9-7.3.15-h63376dd_0.tar.bz2
Copied file: linux-ppc64le/pypy3.9-7.3.15-h4020351_0.tar.bz2
Copied 2 files!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pypy3.9 (7.3.13) contains an invalid importlib.machinery.EXTENSION_SUFFIXES on ppc64le
2 participants