Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V7.3.12 #105

Merged
merged 10 commits into from
Aug 29, 2023
Merged

V7.3.12 #105

merged 10 commits into from
Aug 29, 2023

Conversation

mattip
Copy link
Contributor

@mattip mattip commented Aug 13, 2023 •
edited
Loading

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Update the recipe. I removed version from the jinja2 template since python3.8 does not have a 7.3.12 release. Looking at the changelog for 7.3.12, I don't see anything that is critical for 3.8, but the backported fixes for functools may allow some progress with the pandas feedstock. Anyhow I think CPython and PyPy python3.8 will be dropped soon after the migration of CPython 3.12 starts, which should not too far in the future.

I would like to add a solution for #101 as well.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@mattip mattip force-pushed the v7.3.12 branch 2 times, most recently from 3e93741 to 302fca1 Compare August 14, 2023 10:59
@mattip
Copy link
Contributor Author

mattip commented Aug 15, 2023

CI is green. Anyone want to review?

h-vetinari
h-vetinari approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM (aside from small nits; did not verify the patches), but as I haven't followed the discussion in #101, I'll leave the approval to @isuruf.

recipe/bld.bat Outdated Show resolved Hide resolved
recipe/bld.bat Outdated Show resolved Hide resolved
recipe/build.sh Outdated Show resolved Hide resolved
mattip
mattip commented Aug 15, 2023
View reviewed changes
recipe/bld.bat Outdated
REM Copy required DLLs so pypy can be used without activating the environment
copy /b %PREFIX%\Library\bin\libexpat.dll %PREFIX%
copy /b %PREFIX%\Library\bin\libbz2.dll %PREFIX%
copy /b %PREFIX%\Library\bin\ffi-8.dll %PREFIX%
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isuruf this is the part that copies the 3 dlls in repsonse to #101

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't copy them in this package. The copies will have precedence over the ones in %PREFIX%\Library\bin which get upgraded through their own conda packages.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, looks good to me.

@mattip mattip mentioned this pull request Aug 17, 2023
Closed
@mattip
Copy link
Contributor Author

mattip commented Aug 28, 2023

I commented out the fix for #101. That issue will have to wait for another day.

@mattip
Copy link
Contributor Author

mattip commented Aug 28, 2023

@conda-forge-admin, please rerender

@mattip
Copy link
Contributor Author

mattip commented Aug 29, 2023

Since the controversial fix for #101 was removed, I will merge this.

@mattip mattip merged commit a8ab262 into conda-forge:main Aug 29, 2023
@h-vetinari
Copy link
Member

Quick question: are you planning to do the aarch/ppc builds like for the last version bump (#99)?

@mattip
Copy link
Contributor Author

mattip commented Aug 29, 2023

I want to make some progress with pandas first, perhaps there are more problems in the feedstock that need to be fixed.

@h-vetinari h-vetinari mentioned this pull request Aug 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-vetinari h-vetinari h-vetinari approved these changes

@isuruf isuruf Awaiting requested review from isuruf isuruf is a code owner

@ocefpaf ocefpaf Awaiting requested review from ocefpaf ocefpaf is a code owner

@ohadravid ohadravid Awaiting requested review from ohadravid ohadravid is a code owner

@omerbenamram omerbenamram Awaiting requested review from omerbenamram omerbenamram is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattip @h-vetinari @isuruf