Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyinstaller v5.13.2 #98

Merged
merged 4 commits into from
Oct 27, 2023

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Closes: #97

Pending Dependency Version Updates

Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.

Name Upstream Version Current Version
pyinstaller-hooks-contrib 2023.8 Anaconda-Server Badge
pywin32 306 Anaconda-Server Badge

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.

Packages found by source code inspection but not in the meta.yaml:

  • pytest

Packages found in the meta.yaml but not found by source code inspection:

  • pyinstaller-hooks-contrib

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/6018424874, please use this URL for debugging.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@nicoddemus
Copy link
Member

This is erroring out with AttributeError: 'Namespace' object has no attribute 'recipe' inside conda:

If submitted, this report will be used by core maintainers to improve
future releases of conda.

    Traceback (most recent call last):
      File "C:\Miniforge\lib\site-packages\conda\exceptions.py", line 1132, in __call__
        return func(*args, **kwargs)
      File "C:\Miniforge\lib\site-packages\conda\cli\main.py", line 69, in main_subshell
        exit_code = do_call(args, p)
      File "C:\Miniforge\lib\site-packages\conda\cli\conda_argparse.py", line 115, in do_call
        return args.plugin_subcommand.action(sys.argv[2:])
      File "C:\Miniforge\lib\site-packages\conda_build\plugin.py", line 10, in build
        execute(*args, **kwargs)
      File "C:\Miniforge\lib\site-packages\conda_build\cli\main_build.py", line 516, in execute
        _parser, args = parse_args(args)
      File "C:\Miniforge\lib\site-packages\conda_build\cli\main_build.py", line 470, in parse_args
        check_recipe(args.recipe)
    AttributeError: 'Namespace' object has no attribute 'recipe'

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@nicoddemus
Copy link
Member

@conda-forge-admin, please rerender

@nicoddemus
Copy link
Member

@conda-forge/python any hints what might be causing this error?

# >>>>>>>>>>>>>>>>>>>>>> ERROR REPORT <<<<<<<<<<<<<<<<<<<<<<
If submitted, this report will be used by core maintainers to improve

future releases of conda.
    Traceback (most recent call last):
      File "C:\Miniforge\lib\site-packages\conda\exceptions.py", line 1132, in __call__
        return func(*args, **kwargs)
      File "C:\Miniforge\lib\site-packages\conda\cli\main.py", line 69, in main_subshell
        exit_code = do_call(args, p)
      File "C:\Miniforge\lib\site-packages\conda\cli\conda_argparse.py", line 115, in do_call
        return args.plugin_subcommand.action(sys.argv[2:])
      File "C:\Miniforge\lib\site-packages\conda_build\plugin.py", line 10, in build
        execute(*args, **kwargs)
      File "C:\Miniforge\lib\site-packages\conda_build\cli\main_build.py", line 516, in execute
        _parser, args = parse_args(args)
      File "C:\Miniforge\lib\site-packages\conda_build\cli\main_build.py", line 470, in parse_args
        check_recipe(args.recipe)
    AttributeError: 'Namespace' object has no attribute 'recipe'

Google didn't turn out much.

Is this a known issue? Should I open a ticket somewhere?

@ocefpaf
Copy link
Member

ocefpaf commented Oct 24, 2023

Google didn't turn out much.

Is this a known issue? Should I open a ticket somewhere?

Probably not. My guess is that the build stack changed to much since Aug 29th and the web rerender did not work. I rerendered it locally, let's see how it goes.


Edit: spoke too soon. The failure persists on Windows :-/

@nicoddemus
Copy link
Member

Yeah the other PRs are stalled with the same errors: https://github.com/conda-forge/pyinstaller-feedstock/pulls.

@ejwcobra
Copy link

@nicoddemus @ocefpaf any luck with this? Perhaps you already saw this in your own searches but I searched google for the error message and found a StackOverflow question with no answers (not helpful) and an issue in the conda-build github repo that recommended upgrading conda.

I'd be happy to provide any assistance I can, but unfortunately I don't have any experience with publishing conda packages so I might be useless in this regard.

@isuruf
Copy link
Member

isuruf commented Oct 27, 2023

@conda-forge-admin, rerender

@isuruf isuruf added the automerge Merge the PR when CI passes label Oct 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • travis: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@isuruf isuruf closed this Oct 27, 2023
@isuruf isuruf reopened this Oct 27, 2023
@github-actions github-actions bot merged commit 2c874c5 into conda-forge:main Oct 27, 2023
19 checks passed
@@ -1,6 +1,5 @@
build_platform:
osx_arm64: osx_64
build_with_mambabuild: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I would never have guessed that!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know. 👍

@ejwcobra
Copy link

Thanks for figuring this out, I really appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants