Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 3.30.4 and start providing a Windows build #13

Merged
merged 3 commits into from
Jan 30, 2019

Conversation

pkgw
Copy link
Contributor

@pkgw pkgw commented Jan 27, 2019

The new series can use the Meson build system, which makes building on Windows tractable.

Meson is only available for Python >= 3.5, which means that we have to lose support for Python 2.x. In my judgment it's OK to make the jump.

  • Used a fork of the feedstock to propose changes
  • Reset the build number to 0 (the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Closes #8.

pkgw added 2 commits January 27, 2019 13:37
This series can use the Meson build system, which makes building on Windows
tractable.

Meson is only available for Python >= 3.5, which means that we have to lose
support for Python 2.7. In my judgment it's OK to make the jump.
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

The unit tests need a DYLD_LIBRARY_PATH hack to match that on other platforms.
@pkgw
Copy link
Contributor Author

pkgw commented Jan 27, 2019

OK, CI passes. @sebastian-luna-valero @ocefpaf @isuruf any opinions about the change here — we add Windows as a platform, but lose support for Python 2.x?

@ocefpaf
Copy link
Member

ocefpaf commented Jan 27, 2019

OK, CI passes. @sebastian-luna-valero @ocefpaf @isuruf any opinions about the change here — we add Windows as a platform, but lose support for Python 2.x?

We lose what? Never heard of it 😜

@pkgw pkgw merged commit e0921cf into conda-forge:master Jan 30, 2019
@pkgw pkgw deleted the bump-meson branch January 30, 2019 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants