Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for libboost 1.82 + flann 1.9.2 + CUDA 11.8 + CUDA 12 #10

Merged
merged 16 commits into from
Oct 22, 2023

Conversation

h-vetinari
Copy link
Member

Bot could not open a PR due to pybind pin

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member Author

@Tobias-Fischer
So I unpinned pybind here, because that's what kept the bot from opening this PR, but it seems this might be the reason this is now failing:

import: 'pycolmap'
Traceback (most recent call last):
  File "/home/conda/feedstock_root/build_artifacts/pycolmap_1696851618019/test_tmp/run_test.py", line 2, in <module>
    import pycolmap
ImportError: generic_type: cannot initialize type "KeysView[int]": an object with that name is already defined

Any ideas?

@h-vetinari
Copy link
Member Author

Gentle ping @Tobias-Fischer

@Tobias-Fischer
Copy link
Contributor

I think we might be running into pybind/pybind11#4529

@Tobias-Fischer
Copy link
Contributor

The pybind11 issue seems to be resolved.

We are now running into the same issues as in #9:

  /home/conda/feedstock_root/build_artifacts/pycolmap_1697589028940/_build_env/bin/../lib/gcc/aarch64-conda-linux-gnu/10.4.0/../../../../aarch64-conda-linux-gnu/bin/ld: /usr/local/cuda/lib64/libcudart_static.a(cudart_static.o): Relocations in generic ELF (EM: 62)

I have no idea how to tackle it though, and I am not sure why it appears now.

@jakirkham
Copy link
Member

Well it is linking to the x86_64 library while building of aarch64. The linker understandably errors

The question is, what is handing the linker the x86_64 library instead of the aarch64 library?

This probably involves more knowledge of how the build here occurs (probably combined with more verbose builds)

@jakirkham
Copy link
Member

jakirkham commented Oct 18, 2023

Also this warning on CI seems important. Maybe worth raising upstream?

  CMake Warning (dev) at /home/conda/feedstock_root/build_artifacts/pycolmap_1697589028940/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/share/colmap/COLMAPConfig.cmake:211 (find_package):
    Policy CMP0146 is not set: The FindCUDA module is removed.  Run "cmake
    --help-policy CMP0146" for policy details.  Use the cmake_policy command to
    set the policy and suppress this warning.

Edit: Seems like this should have been fixed ( colmap/colmap#1693 ). Is something here out-of-date? Like colmap or some vendored bits of it in pycolmap?

@Tobias-Fischer
Copy link
Contributor

I think the issue is that this change has not been incorporated in the CmakeConfig of colmap that is being used here: https://github.com/colmap/colmap/blob/43de802cfb3ed2bd155150e7e5e3e8c8dd5aaa3e/cmake/CMakeConfig.cmake.in#L206

@Tobias-Fischer Tobias-Fischer changed the title Rebuild for libboost 1.82 Rebuild for libboost 1.82 + flann 1.9.2 Oct 21, 2023
@Tobias-Fischer
Copy link
Contributor

@conda-forge-admin please rerender

@Tobias-Fischer Tobias-Fischer changed the title Rebuild for libboost 1.82 + flann 1.9.2 Rebuild for libboost 1.82 + flann 1.9.2 + CUDA 11.8 + CUDA 12 Oct 22, 2023
@Tobias-Fischer
Copy link
Contributor

@conda-forge-admin please rerender

@Tobias-Fischer
Copy link
Contributor

@conda-forge-admin please rerender

conda-forge-webservices[bot] and others added 2 commits October 22, 2023 01:50
@Tobias-Fischer Tobias-Fischer merged commit 64aa218 into conda-forge:main Oct 22, 2023
49 checks passed
@jakirkham
Copy link
Member

Thank you both! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants