Bump pybind11-abi to 10 to reflect the fact that PYBIND11_INTERNALS_ID is not used anymore to track compatibility
#106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversaro
requested review from
SylvainCorlay,
ax3l,
henryiii and
wjakob
as code owners
|
@conda-forge-admin, please rerender |
|
fyi @conda-forge/pybind11 |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
|
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
On hold while we discuss pybind/pybind11#5296 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in #96 (comment) .
The idea is that since pybind/pybind11#5296
PYBIND11_INTERNALS_IDis not used anymore to assess compatibility between library compiled with different pybind11 versions, it does not make sense anymore forpybind11-abito trackPYBIND11_INTERNALS_ID.For this reason, this PR also remove the check that
pybind11-abiis equal toPYBIND11_INTERNALS_ID.Fix #96 .
Note that this will not solve or handle the fact that pybind11 bindings compiled with different gcc or clang major versions (#77) or msvc minor versions (#95) are incompatible.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)