build pybamm-base with no optional deps #70

Saransh-cpp · 2024-12-03T11:06:27Z

Checklist

Used a personal fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
Ensured the license file is being packaged.

Saransh-cpp · 2024-12-03T11:06:35Z

@conda-forge-admin, please rerender

conda-forge-admin · 2024-12-03T11:08:03Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

❌ The outputs section contained an unexpected subsection name. run is not a valid subsection name.

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12138356499. Examine the logs at this URL for more detail.}

conda-forge-admin · 2024-12-03T11:08:47Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the GitHub Actions workflow below for more details. You can also ping conda-forge/core (using the @ notation) for further assistance or you can try rerendering locally.

The following suggestions might help debug any issues:

Is the recipe/{meta.yaml,recipe.yaml} file valid?
If there is a recipe/conda-build-config.yaml file in the feedstock make sure that it is compatible with the current global pinnnings.
Is the fork used for this PR on an organization or user GitHub account? Automated rerendering via the webservices admin bot only works for user GitHub accounts.

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12138363357. Examine the logs at this URL for more detail.}

conda-forge-admin · 2024-12-03T11:30:23Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

agriyakhetarpal · 2024-12-03T19:14:06Z

Great idea, thanks for leading this effort, @Saransh-cpp! Please let me know if you would need help with testing this somehow. Would this approach remain possible with platform-specific recipes later on when we start on #65? Also, tagging @prady0t here from the PyBaMM issue in case he is interested in reviewing 👋

recipe/meta.yaml

Saransh-cpp · 2024-12-03T20:29:50Z

Tried debugging this for an hour but couldn't get it to run, and now that the hackathon is over, I would only be able to look at the error next week 😢

recipe/meta.yaml

conda-forge-admin · 2024-12-09T17:29:24Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

ℹ️ Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12240964081. Examine the logs at this URL for more detail.}

recipe/meta.yaml

conda-forge-admin · 2024-12-09T17:35:44Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

Saransh-cpp

Note for reviewers: please make sure that I did not miss any dependency 😬

Saransh-cpp · 2024-12-09T17:35:48Z

recipe/meta.yaml

+        - {{ pin_subpackage('pybamm-base', exact=True) }}
+        # Battery Parameter eXchange format
+        - bpx
+        # Progress bars
+        - tqdm
+        # Plotting
+        - imageio >=2.3.0
+        - matplotlib-base >=3.6.0
+        # Cite
+        - pybtex >=0.24.0
+        # JAX
+        - jax 0.4.27
+        - jaxlib 0.4.27
+        # Other dependencies
+        - scikit-fem >=8.1.0
+        # - iree-compiler -- not available on conda


Everything except dev, docs, and examples.

Saransh-cpp · 2024-12-09T17:36:11Z

recipe/meta.yaml

+        - python >={{ python_min }},<{{ python_max }}
+        - anytree >=2.8.0
+        - casadi >=3.6.7
+        - posthog >=3.6.5
+        - numpy >=1.23.5,<2.0.0
+        - pandas >=1.5.0
+        - pooch >=1.8.1
+        - scipy >=1.11.4
+        - sympy >=1.12
+        - typing-extensions >=4.10.0
+        - xarray >=2022.6.0
+        - pyyaml
+        - platformdirs


Required dependencies for pybamm-base.

recipe/meta.yaml

agriyakhetarpal

Thanks, @Saransh-cpp! I wonder if we can document the fact that the "examples" extra isn't available in conda-forge's PyBaMM distribution and that users should run conda/mamba install -c conda-forge jupyter separately? Also, I think we should update the installation guide upstream about this change in general (and perhaps add an entry to the release notes for the next release as well).

agriyakhetarpal · 2024-12-09T17:54:15Z

recipe/meta.yaml

+      host:
+        - pip
+        - python {{ python_min }}
+        - setuptools >=64


I think we will also require wheel (note that setuptools injects wheel when building wheels) for setuptools <=70.1.0; we have to list it explicitly because we import it in our setup script to override the bdist_wheel class, so setuptools's injection is not enough. It doesn't fail right now because the extension module isn't being built, but it is going to fail later. Once we bump to the noted setuptools version (I'll open a PR in PyBaMM and tag you there), we will be in a better position. Not something to do here, but we could note it as a comment here for future upgrades :)

recipe/meta.yaml

Saransh-cpp · 2024-12-09T18:06:03Z

Thanks for the review!

document the fact that the "examples" extra isn't available in conda-forge's

Yes, I think this would require some work on upstream docs in general. I will open an issue in PyBaMM once this is merged.

and perhaps add an entry to the release notes for the next release as well

Will mention this on slack.

Saransh-cpp added 2 commits December 3, 2024 11:05

build pybamm-base with no optional deps

d719085

bump build number

2a4f706

Saransh-cpp requested review from agriyakhetarpal, priyanshuone6, tlestang and valentinsulzer as code owners December 3, 2024 11:06

Saransh-cpp marked this pull request as draft December 3, 2024 11:06

Saransh-cpp mentioned this pull request Dec 3, 2024

Possible to split optional and required dependencies on conda pybamm-team/PyBaMM#4342

Closed

fix indentation

ad61c07

Saransh-cpp added 4 commits December 3, 2024 11:41

do not use PYTHON

be84dea

BPX is not on conda-forge

fb340a4

use pybamm-base as a dep

6f72550

no script for pybamm

1c40412

agriyakhetarpal reviewed Dec 3, 2024

View reviewed changes

recipe/meta.yaml Outdated Show resolved Hide resolved

Saransh-cpp commented Dec 3, 2024

View reviewed changes

recipe/meta.yaml Outdated Show resolved Hide resolved

Update version pins for JAX libs

7384bc7

Saransh-cpp commented Dec 3, 2024

View reviewed changes

recipe/meta.yaml Outdated Show resolved Hide resolved

no host for pybamm

539f384

Saransh-cpp commented Dec 5, 2024

View reviewed changes

recipe/meta.yaml Outdated Show resolved Hide resolved

Update recipe/meta.yaml

2b4e00f

Saransh-cpp mentioned this pull request Dec 9, 2024

Add pybamm-base conda-forge/admin-requests#1213

Merged

19 tasks

Saransh-cpp added 2 commits December 9, 2024 17:14

pybamm-base approved

0a777b3

update deps

689c7da

use matplotlib-base

b0954d8

Saransh-cpp commented Dec 9, 2024

View reviewed changes

recipe/meta.yaml Outdated Show resolved Hide resolved

rm jupyter

c35e048

Saransh-cpp commented Dec 9, 2024

View reviewed changes

Saransh-cpp marked this pull request as ready for review December 9, 2024 17:56

Saransh-cpp requested a review from agriyakhetarpal December 9, 2024 17:56

Saransh-cpp commented Dec 9, 2024

View reviewed changes

recipe/meta.yaml Show resolved Hide resolved

recipe/meta.yaml Show resolved Hide resolved

comment about lithium_metal

8dc46d0

agriyakhetarpal approved these changes Dec 9, 2024

View reviewed changes

Saransh-cpp commented Dec 9, 2024

View reviewed changes

recipe/meta.yaml Show resolved Hide resolved

add a comment wbout wheel

7819b5d

Saransh-cpp merged commit 6db715f into conda-forge:main Dec 9, 2024
4 checks passed

Saransh-cpp deleted the spit-deps branch December 9, 2024 18:13

agriyakhetarpal mentioned this pull request Dec 9, 2024

Drop dependence on wheel at build time pybamm-team/PyBaMM#4652

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build pybamm-base with no optional deps #70

build pybamm-base with no optional deps #70

Saransh-cpp commented Dec 3, 2024

Saransh-cpp commented Dec 3, 2024

conda-forge-admin commented Dec 3, 2024

conda-forge-admin commented Dec 3, 2024

conda-forge-admin commented Dec 3, 2024

agriyakhetarpal commented Dec 3, 2024

Saransh-cpp commented Dec 3, 2024

conda-forge-admin commented Dec 9, 2024

conda-forge-admin commented Dec 9, 2024

Saransh-cpp left a comment

Saransh-cpp Dec 9, 2024

Saransh-cpp Dec 9, 2024

agriyakhetarpal left a comment

agriyakhetarpal Dec 9, 2024

Saransh-cpp commented Dec 9, 2024

build pybamm-base with no optional deps #70

build pybamm-base with no optional deps #70

Conversation

Saransh-cpp commented Dec 3, 2024

Saransh-cpp commented Dec 3, 2024

conda-forge-admin commented Dec 3, 2024

conda-forge-admin commented Dec 3, 2024

conda-forge-admin commented Dec 3, 2024

agriyakhetarpal commented Dec 3, 2024

Saransh-cpp commented Dec 3, 2024

conda-forge-admin commented Dec 9, 2024

conda-forge-admin commented Dec 9, 2024

Saransh-cpp left a comment

Choose a reason for hiding this comment

Saransh-cpp Dec 9, 2024

Choose a reason for hiding this comment

Saransh-cpp Dec 9, 2024

Choose a reason for hiding this comment

agriyakhetarpal left a comment

Choose a reason for hiding this comment

agriyakhetarpal Dec 9, 2024

Choose a reason for hiding this comment

Saransh-cpp commented Dec 9, 2024