Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v2.1.2 and remove special config for llvm #48

Merged
merged 12 commits into from
Dec 21, 2023

Conversation

johnlees
Copy link
Contributor

@johnlees johnlees commented Dec 19, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Fixes #42

Now upstream is fixed, I hope, can unpin llvm/clang versions and remove libcxx

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@johnlees
Copy link
Contributor Author

@conda-forge-admin, please rerender

@jakirkham
Copy link
Member

Thanks John! 🙏

It looks like the version bump is missing from the changes

@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

conda-forge-webservices[bot] and others added 2 commits December 19, 2023 19:22
@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/pp-sketchlib-feedstock/actions/runs/7266618752.

@jakirkham
Copy link
Member

jakirkham commented Dec 19, 2023

Manually added the migrator files from #45 , #46 and #47 as re-rendering won't add them alone. They come from conda-forge-pinning-feedstock's recipe/migrations directory where all the migrators live (until they are completed at which point they are removed from that directory). Hope that is ok

@johnlees
Copy link
Contributor Author

Thanks John! 🙏

It looks like the version bump is missing from the changes

Forgot to actually commit the recipe!! Done now

@johnlees
Copy link
Contributor Author

@conda-forge-admin, please rerender

Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/pp-sketchlib-feedstock/actions/runs/7273814345.

@johnlees
Copy link
Contributor Author

johnlees commented Dec 20, 2023

OS X failure:

import: 'pp_sketchlib'
Traceback (most recent call last):
  File "/Users/runner/miniforge3/conda-bld/pp-sketchlib_1703066779188/test_tmp/run_test.py", line 2, in <module>
    import pp_sketchlib
ImportError: dlopen(/Users/runner/miniforge3/conda-bld/pp-sketchlib_1703066779188/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_p/lib/python3.8/site-packages/pp_sketchlib.cpython-38-darwin.so, 2): Symbol not found: _H5P_CLS_LINK_CREATE_ID_g
  Referenced from: /Users/runner/miniforge3/conda-bld/pp-sketchlib_1703066779188/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_p/lib/python3.8/site-packages/pp_sketchlib.cpython-38-darwin.so
  Expected in: flat namespace
 in /Users/runner/miniforge3/conda-bld/pp-sketchlib_1703066779188/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_p/lib/python3.8/site-packages/pp_sketchlib.cpython-38-darwin.so

May need patching in the CMakeLists.txt file

CUDA 12 issue is the same as before: #43. This has been fixed in the master branch of pybind11 but hasn't entered a release yet. So we'll need to keep gcc11 for now

@johnlees johnlees mentioned this pull request Dec 20, 2023
3 tasks
@johnlees
Copy link
Contributor Author

@conda-forge-admin, please rerender

@johnlees
Copy link
Contributor Author

@conda-forge-admin, please rerender

@johnlees
Copy link
Contributor Author

johnlees commented Dec 20, 2023

@jakirkham this is now all passing and ready to merge – would you mind just quickly checking all files/pinnings are as you'd expect

@johnlees johnlees linked an issue Dec 20, 2023 that may be closed by this pull request
@jakirkham
Copy link
Member

LGTM. Thanks for all your hard work on this John! 🙏

Added a fixes note in the OP for the macOS LLVM issue. Hope that is ok 🙂

@johnlees johnlees merged commit f5dda01 into conda-forge:main Dec 21, 2023
22 checks passed
@johnlees johnlees deleted the v212 branch December 21, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert macOS LLVM 14 pinning
2 participants