-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to v2.1.2 and remove special config for llvm #48
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.12.19.13.04.28
Thanks John! 🙏 It looks like the version bump is missing from the changes |
@conda-forge-admin , please re-render |
…nda-forge-pinning 2023.12.19.13.04.28
@conda-forge-admin , please re-render |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/pp-sketchlib-feedstock/actions/runs/7266618752. |
Manually added the migrator files from #45 , #46 and #47 as re-rendering won't add them alone. They come from |
Forgot to actually commit the recipe!! Done now |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/pp-sketchlib-feedstock/actions/runs/7273814345. |
OS X failure:
May need patching in the CMakeLists.txt file CUDA 12 issue is the same as before: #43. This has been fixed in the master branch of pybind11 but hasn't entered a release yet. So we'll need to keep gcc11 for now |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.12.19.13.04.28
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.12.19.13.04.28
@jakirkham this is now all passing and ready to merge – would you mind just quickly checking all files/pinnings are as you'd expect |
LGTM. Thanks for all your hard work on this John! 🙏 Added a fixes note in the OP for the macOS LLVM issue. Hope that is ok 🙂 |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)Fixes #42
Now upstream is fixed, I hope, can unpin llvm/clang versions and remove
libcxx