Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make noarch #32

Merged
merged 4 commits into from
Oct 31, 2022
Merged

Make noarch #32

merged 4 commits into from
Oct 31, 2022

Conversation

BastianZim
Copy link
Member

@BastianZim BastianZim commented Oct 30, 2022

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

This PR makes this package noarch. Ref: https://conda-forge.org/docs/maintainer/knowledge_base.html#non-version-specific-python-packages
Additionally, it updates the recipe structure to the standard Grayskull one

Ref: conda-forge/conda-forge.github.io#1840

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@BastianZim
Copy link
Member Author

@conda-forge-admin, please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
@BastianZim BastianZim requested review from isuruf and nicoddemus and removed request for nicoddemus, johnnygenomics, adriendelsalle and isuruf October 31, 2022 15:27
@nicoddemus nicoddemus merged commit 9d83abc into conda-forge:main Oct 31, 2022
@BastianZim BastianZim deleted the noarch branch October 31, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants