-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perspective v0.6.2 #18
perspective v0.6.2 #18
Conversation
…da-forge-pinning 2021.02.24.15.35.41
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin please rerender |
…da-forge-pinning 2021.02.25.19.30.33
@conda-forge/perspective This is ready for review. |
I need to rewrite the meta now that we automatically download and statically link arrow , also need to see if we can expand onto win and Mac now that the build process is a bit more flexible. |
From the Arrow developer perspective: Why do you need to statically include With the conda-forge hat: We don't want downloads inside the build. Could we somehow work around this in the conda setting to make the build offline-capable? |
@xhochy for 1, at the end of the day it became too difficult to link against the arrow shared libraries in a reliable way. E.g. on windows making sure that our dlls could figure out arrow dlls meant either doing runtime nonsense against the hope of
For conda forge, our external dependencies are listed here (everything inside I think we're pretty done with making tweaks to this as is pretty frustrating across environments. If all of these libraries were available within conda forge in a standard way across all operating systems, we could modify the build dep function to first check if they exist already. But at the end of the day, these are all statically linked into the output libraries and only used as completely internally or for transport to/from the corresponding js libraries (as is the case for arrow). Nothing vendored is exposed anywhere externally. |
Thanks for the information and the link 👍 I'm not here to block anything but just collecting feedback about these issues. Linking across Python package boundaries especially outside of conda-controlled environments is quite hard and it seems that every Note that one workaround to do less vendoring on conda-forge but still give your uses a bit of flexibility in their pinnings is to simply build for multiple Arrow versions as we do in https://github.com/conda-forge/snowflake-connector-python-feedstock/blob/e9824ea18f606634ffd152a30d436514a4a7bd5a/recipe/conda_build_config.yaml#L1 |
yep definitely
Its slightly more tricky (but a lot easier after arrow c stuff and protocol stabilization) because the arrow compiled on the python side must be compatible with the arrow compiled to webassembly on the JS side if you want to use the two together (as in the JupyterLab extension of the standalone examples like this one). But we'll keep this in mind, and I'll take a look at filling in some of the conda gaps on our C++ dependencies so that others can have an easier time. |
It is very likely that the current package version for this feedstock is out of date.
Notes for merging this PR:
Checklist before merging this PR:
license_file
is packagedNote that the bot will stop issuing PRs if more than 3 Version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
NEW: If you want these PRs to be merged automatically, make an issue with
@conda-forge-admin,
please add bot automerge
in the title and merge the resulting PR. This command will add our new bot automerge feature to your feedstock!If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot.
The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (
conda install -c conda-forge rever
) and pip (pip install re-ver
) installable.Finally, feel free to drop us a line if there are any issues!
This PR was generated by https://github.com/regro/autotick-bot/actions/runs/596701519, please use this URL for debugging
Here is a list of all the pending dependencies (and their versions) for this repo. Please double check all dependencies before merging.
Dependency Analysis
Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add
bot: inspection: false
to yourconda-forge.yml
. If you encounter issues with this feature please ping the bot teamconda-forge/bot
.Analysis of the source code shows a discrepancy between the library's imports and the package's stated requirements in the meta.yaml.
Packages found by inspection but not in the meta.yaml: