Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for vtk930 and migrate from qt-main (qt5) to qt6-main #65

Merged
merged 6 commits into from
Jun 23, 2024

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Jun 19, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • You are setting c_stdlib_version below the current global baseline in conda-forge (10.13). If this is your intention, you also need to override MACOSX_DEPLOYMENT_TARGET (with the same value) locally.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@traversaro traversaro mentioned this pull request Jun 19, 2024
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/pcl-feedstock/actions/runs/9582199238.

@traversaro
Copy link
Contributor Author

I did this assuming that the qt of vtk and qt of pcl could be difference, but that is not the case: in code like https://github.com/PointCloudLibrary/pcl/blob/b0b25194f214112e3eb3db876f33960fd85f5794/apps/cloud_composer/src/items/fpfh_item.cpp#L36-L37 the two are interacting and expected to be the same version. At this point, probably we can just to switch to use qt6-main .

@traversaro traversaro changed the title Rebuild for vtk930 with additional fixes Rebuild for vtk930 and migrate from qt-main (qt5) to qt6-main Jun 19, 2024
@traversaro
Copy link
Contributor Author

Last failure:

[ 35%] Building CXX object visualization/CMakeFiles/pcl_visualization.dir/src/interactor_style.cpp.o
/Users/runner/miniforge3/conda-bld/pcl_1718805078887/work/visualization/src/interactor_style.cpp:613:19: error: 'exists' is unavailable: introduced in macOS 10.15 - see https://conda-forge.org/docs/maintainer/knowledge_base.html#newer-c-features-with-old-sdk
      if (pcl_fs::exists (camera_file_))
                  ^
/Users/runner/miniforge3/conda-bld/pcl_1718805078887/work/visualization/src/interactor_style.cpp:613:27: error: '~path' is unavailable: introduced in macOS 10.15 - see https://conda-forge.org/docs/maintainer/knowledge_base.html#newer-c-features-with-old-sdk
      if (pcl_fs::exists (camera_file_))
                          ^
/Users/runner/miniforge3/conda-bld/pcl_1718805078887/_build_env/bin/../include/c++/v1/__filesystem/path.h:509:3: note: '~path' has been explicitly marked unavailable here
  ~path() = default;
  ^
3 errors generated.
make[2]: *** [visualization/CMakeFiles/pcl_visualization.dir/build.make:90: visualization/CMakeFiles/pcl_visualization.dir/src/interactor_style.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:1204: visualization/CMakeFiles/pcl_visualization.dir/all] Error 2
make: *** [Makefile:136: all] Error 2
Traceback (most recent call last):
  File "/Users/runner/miniforge3/bin/conda-build", line 11, in <module>
    sys.exit(main())
  File "/Users/runner/miniforge3/lib/python3.10/site-packages/conda_build/deprecations.py", line 71, in inner
    return func(*args, **kwargs)
  File "/Users/runner/miniforge3/lib/python3.10/site-packages/conda_build/cli/main_build.py", line 593, in main
    execute(sys.argv[1:])
  File "/Users/runner/miniforge3/lib/python3.10/site-packages/conda_build/cli/main_build.py", line 572, in execute
    outputs = api.build(
  File "/Users/runner/miniforge3/lib/python3.10/site-packages/conda_build/api.py", line 254, in build
    return build_tree(
  File "/Users/runner/miniforge3/lib/python3.10/site-packages/conda_build/build.py", line 3789, in build_tree
    packages_from_this = build(
  File "/Users/runner/miniforge3/lib/python3.10/site-packages/conda_build/build.py", line 2670, in build
    utils.check_call_env(
  File "/Users/runner/miniforge3/lib/python3.10/site-packages/conda_build/utils.py", line 435, in check_call_env
    return _func_defaulting_env_to_os_environ("call", *popenargs, **kwargs)
  File "/Users/runner/miniforge3/lib/python3.10/site-packages/conda_build/utils.py", line 411, in _func_defaulting_env_to_os_environ
    raise subprocess.CalledProcessError(proc.returncode, _args)
subprocess.CalledProcessError: Command '['/bin/bash', '-o', 'errexit', '/Users/runner/miniforge3/conda-bld/pcl_1718805078887/work/conda_build.sh']' returned non-zero exit status 2.

not sure why it was not appening before as 10.12 was fixed. Anyhow, we can skip this checks as described in https://conda-forge.org/docs/maintainer/knowledge_base/#newer-c-features-with-old-sdk .

@traversaro
Copy link
Contributor Author

@conda-forge/pcl the PR is ready for review.

@Tobias-Fischer
Copy link
Contributor

Thanks a lot @traversaro! This looks good - however, should we try and build ppc with qt6 support? I think it’s available if I’m not mistaken. If it works out of the box I’d suggest to enable support; if it doesn’t, then let’s keep it as is. What do you think?

@traversaro
Copy link
Contributor Author

Thanks a lot @traversaro! This looks good - however, should we try and build ppc with qt6 support? I think it’s available if I’m not mistaken. If it works out of the box I’d suggest to enable support; if it doesn’t, then let’s keep it as is. What do you think?

Looking at https://anaconda.org/conda-forge/qt6-main it does not seem that linux-ppc64le is available?

@Tobias-Fischer
Copy link
Contributor

Thanks for checking - all good then on my side. Will merge unless there are objections in the next 48 hours.

@traversaro
Copy link
Contributor Author

It seems no one is against this, fyi @Tobias-Fischer .

@Tobias-Fischer Tobias-Fischer merged commit c4e4dae into conda-forge:main Jun 23, 2024
8 checks passed
@traversaro
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants