-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild for vtk930 and migrate from qt-main (qt5) to qt6-main #65
Conversation
…nda-forge-pinning 2024.06.19.11.45.47
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/pcl-feedstock/actions/runs/9582199238. |
I did this assuming that the qt of vtk and qt of pcl could be difference, but that is not the case: in code like https://github.com/PointCloudLibrary/pcl/blob/b0b25194f214112e3eb3db876f33960fd85f5794/apps/cloud_composer/src/items/fpfh_item.cpp#L36-L37 the two are interacting and expected to be the same version. At this point, probably we can just to switch to use qt6-main . |
Last failure:
not sure why it was not appening before as 10.12 was fixed. Anyhow, we can skip this checks as described in https://conda-forge.org/docs/maintainer/knowledge_base/#newer-c-features-with-old-sdk . |
@conda-forge/pcl the PR is ready for review. |
Thanks a lot @traversaro! This looks good - however, should we try and build ppc with qt6 support? I think it’s available if I’m not mistaken. If it works out of the box I’d suggest to enable support; if it doesn’t, then let’s keep it as is. What do you think? |
Looking at https://anaconda.org/conda-forge/qt6-main it does not seem that |
Thanks for checking - all good then on my side. Will merge unless there are objections in the next 48 hours. |
It seems no one is against this, fyi @Tobias-Fischer . |
Thanks! |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)