-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild version 1.5.3 for python 3.12 #185
base: v1.5.x
Are you sure you want to change the base?
Conversation
…nda-forge-pinning 2023.10.20.09.48.02
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug. |
Thank you, @ocefpaf, for creating the |
This is a very old version of pandas - Is there a reason you are trying to port it to Python 3.12? Pandas 2.1 is the first version with Python 3.12 support, and a lot of things have changed since pandas 1.5.3, one major one being the build system. So, unfortunately, I don't think this would be possible without a large amount of code changes. |
My intention in creating the v1.5.x branch was to provide a solution for users who are currently using an older version of pandas and need compatibility with Python 3.12. By building a Python 3.12-compatible version of the latest 1.x series, users can gradually update their applications without facing immediate compatibility issues. I have already submitted another PR that reverts the changes back to commit 66ac579 in a single commit, ensuring that the branch is based on the last 1.x version before transitioning to version 2. If the build fails or this approach adds too much maintenance burden, I completely understand and am willing to close both PRs. |
The build for that branch for python 3.12 has also failed. If there is anything I can do to help with the build, I will gladly assist. However, if you believe it is not possible to build for the old version, we can close this PR and potentially remove the v1.5.x branch as well. |
Checklist
conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)NOTE: This PR is not based on the main branch but is based on the latest commit in the main branch before transitioning to version 2, which is 66ac579.