-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove obsolete numpy cap, skip failing PPC tests #163
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/pandas, PTAL If desired, I can join as a maintainer as well. |
thanks @h-vetinari. You're welcome to add yourself as a maintainer if you'd like. |
The cap you removed was in the test requirements, right? (and not in the run-requirements) |
My bad, not sure how I managed to confuse myself on that one. Sorry! |
Fixes #150
In general, such hard caps in the run-requirements are a really bad idea, because they force every user of pandas (through conda-forge) to forego improvements in new numpy versions etc., even though it's about highly localized failures. The better way would be to add this cap in the test requirements.
In either case, such caps should be removed as soon as possible, in this case once the next version is released that contains the fix.
Also, CI on main is failing for PPY, which is not good. I added another commit to fix this.