-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openmpi v5.0.5 #172
openmpi v5.0.5 #172
Conversation
…nda-forge-pinning 2024.07.30.01.49.09
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Yeah, I guess. I'm also not 100% sure this matters. If $LDFLAGS are respected in conda-forge packages, then |
On a somewhat related matter, why are we setting |
the shlib-undefined is related to user runtime compilation and conda-forge's weighed-down default sysroot to older than the one used to build openmpi (not technically the case anymore as of this month). Discussion is in #143 (especially here). Essentially, package compilation is expected to use $LDFLAGS, but I don't think user runtime compilation necessarily should. So the wrappers should include whatever flags are necessary for compilation to basically function, as opposed to doing the opinionated 'right thing' for building a conda-forge package, and I don't believe preferring old sysroot for user environments is the right move, and hope it will stop happening soon after the c_stdlib migration completes, but for now #160 is an alternative, stricter path to a similar result: don't allow openmpi to be installed in an env with older sysroot. This doesn't affect conda-build packages, because sysroot and openmpi don't tend to be in the same env (cross compilation notwithstanding). The downside to #160 is it actually forces downstream packages (if they cross compile, at least) to use the same or greater sysroot, when that's not actually required. So it's perhaps an improvement for runtime compilation for users and a tedious annoyance for packagers. I still don't know if that's a positive tradeoff or not. But |
@minrk All good then , please merge at your earliest convenience, then I can move to PETSc. |
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_file
is packagedInformation about this PR:
@conda-forge-admin,
please add bot automerge
in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.Pending Dependency Version Updates
Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.
Dependency Analysis
We couldn't run dependency analysis due to an internal error in the bot, depfinder, or grayskull. :/ Help is very welcome!
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by - please use this URL for debugging.