-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild for hdf51122 #28
Rebuild for hdf51122 #28
Conversation
…nda-forge-pinning 2022.07.29.09.27.39
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@@ -30,8 +30,7 @@ requirements: | |||
host: | |||
- python | |||
- numpy | |||
- hdf5 # [win] | |||
- hdf5-static # [not win] | |||
- hdf5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this works for the build step we'll need to add it to the run step now too I think, which would be okay I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The run export guarantees that
https://github.com/conda-forge/hdf5-feedstock/blob/main/recipe/meta.yaml#L88
I'm not sure why it can't find the shared library for now. You likely have to help cmake out |
I feel like you're specifications for your selector we're backward compared to what you told me. You were using static libraries on Linux and dynamic on windows. In either case, the conda-forge migration process should ensure that only compatible versions of software are installed together |
Yeah I think I described our installs backward, sorry about that!
Yes that's true for the build process, but at install time I'd rather not force people to use OpenBLAS, which means for now I want to build statically. But as you say, I could migrate to compiling against Netlib, but I expect it to be a bit of work. I can look into that at some point. It still seems a bit odd that this worked on the previous release of hdf5 but now fails. I thought it suggested something important might have changed with the hdf5 build infrastructure, but now I'm thinking it's more likely that the bug is somewhere else (e.g., in cmake or our use of it here), and only now for some reason we see it! |
…nda-forge-pinning 2022.08.19.14.19.32
Okay at least one Linux build passed, I'll continue this in #29 |
This PR has been triggered in an effort to update hdf51122.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/2759767369, please use this URL for debugging.