Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build from source on linux #60

Merged
merged 9 commits into from
Aug 20, 2019
Merged

Build from source on linux #60

merged 9 commits into from
Aug 20, 2019

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Aug 12, 2019

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Fixes #59

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@isuruf
Copy link
Member Author

isuruf commented Aug 12, 2019

@conda-forge-admin, rerender

Copy link
Member

@sodre sodre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think we should have at least someone else review it before merging

@hadim
Copy link
Member

hadim commented Aug 13, 2019

This PR is mixing Zulu builds and custom compiled Java from another source on Linux. I am concern about the possible downstream impacts of this. @ctrueden any thoughts?

@hadim
Copy link
Member

hadim commented Aug 13, 2019

That being said we coule switch from Zulu to AdoptOpenJDK binaries for OSX, Linux and windows.

@isuruf
Copy link
Member Author

isuruf commented Aug 13, 2019

This PR is mixing Zulu builds and custom compiled Java from another source on Linux.

The source is the same for both. I've used AdoptOpenJDK source because they provide source tarball as a single tarball instead of separate tarballs.
On linux, Zulu builds are still used for bootstrapping the JDK build.

That being said we coule switch from Zulu to AdoptOpenJDK binaries for OSX, Linux and windows.

Why? I'm building this from source to prevent vendoring libraries like libfreetype.so so that openjdk and freetype can be co-installable without clobbering

@isuruf
Copy link
Member Author

isuruf commented Aug 13, 2019

I've used the official source from openjdk.java.net
Ready for another review

@mingwandroid
Copy link
Contributor

LGTM!

@isuruf
Copy link
Member Author

isuruf commented Aug 18, 2019

Ping. I'd like to get this merged, so that I can install openjdk and freetype in the same env.

@sodre sodre merged commit 88a3f67 into conda-forge:master Aug 20, 2019
@isuruf isuruf deleted the source branch August 20, 2019 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

package clobbers libfreetype.so
6 participants