-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build from source on linux #60
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, rerender |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I think we should have at least someone else review it before merging
This PR is mixing Zulu builds and custom compiled Java from another source on Linux. I am concern about the possible downstream impacts of this. @ctrueden any thoughts? |
That being said we coule switch from Zulu to AdoptOpenJDK binaries for OSX, Linux and windows. |
The source is the same for both. I've used AdoptOpenJDK source because they provide source tarball as a single tarball instead of separate tarballs.
Why? I'm building this from source to prevent vendoring libraries like |
I've used the official source from openjdk.java.net |
LGTM! |
Ping. I'd like to get this merged, so that I can install |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)Fixes #59