Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple OpenBLAS OpenMP calls to run in parallel #138

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

manopapad
Copy link

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

This PR adds the required build flag to allow OpenMP-capable builds of OpenBLAS to run multiple OpenMP calls at the same time, see:

https://github.com/xianyi/OpenBLAS/blob/28a24a4d4fe3d9cd838c37504dee2493bc10a5e5/Makefile.rule#L93-L98

We would like this functionality in https://github.com/nv-legate/cunumeric, to allow us to instantiate a separate OpenMP group per NUMA domain.

NUM_PARALLEL=32 is the setting we are currently using in cuNumeric (we are building OpenBLAS from source, but would much prefer to be using the conda package), so I just copied that. If you think that is too high, we would be happy with 8, or even 2 if need be. AFAICT the main effect of increasing this number is increased internal memory usage (unclear how much):
https://github.com/xianyi/OpenBLAS/blob/28a24a4d4fe3d9cd838c37504dee2493bc10a5e5/driver/others/blas_server_omp.c#L72-L77
but no change in behavior when no more than 1 concurrent OpenMP calls are active at any time.

I don't know much about the build number versioning above, please let me know how this should be updated.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@isuruf
Copy link
Member

isuruf commented Jun 4, 2022

@conda-forge-admin, rerender

@jjerphan
Copy link
Member

jjerphan commented Sep 8, 2024

Dear @manopapad,

This seems to be a really useful contribution. What is the status of this PR exactly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants