Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Vulkan Rendersystem #15

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Feb 19, 2023

Fix #10 .

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

Copy link
Contributor

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem reasonable to me, but build aren't in a good place.

@traversaro
Copy link
Contributor Author

The error is:

2023-02-19T15:19:55.2703842Z [ 65%] Building CXX object RenderSystems/Vulkan/CMakeFiles/RenderSystem_Vulkan.dir/src/OgreVulkanProgram.cpp.o
2023-02-19T15:19:55.4875045Z In file included from /home/conda/feedstock_root/build_artifacts/ogre-next_1676819376768/work/RenderSystems/Vulkan/src/OgreVulkanProgram.cpp:45:
2023-02-19T15:19:55.4879674Z /home/conda/feedstock_root/build_artifacts/ogre-next_1676819376768/work/RenderSystems/Vulkan/include/OgreVulkanGlslangHeader.h:17:10: fatal error: glslang/Public/ShaderLang.h: No such file or directory
2023-02-19T15:19:55.4880975Z    17 | #include "glslang/Public/ShaderLang.h"
2023-02-19T15:19:55.4881591Z       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2023-02-19T15:19:55.4882089Z compilation terminated.

Probably we also need https://github.com/KhronosGroup/glslang as a dependency?

@traversaro
Copy link
Contributor Author

traversaro commented Feb 19, 2023

The error is:

2023-02-19T15:19:55.2703842Z [ 65%] Building CXX object RenderSystems/Vulkan/CMakeFiles/RenderSystem_Vulkan.dir/src/OgreVulkanProgram.cpp.o
2023-02-19T15:19:55.4875045Z In file included from /home/conda/feedstock_root/build_artifacts/ogre-next_1676819376768/work/RenderSystems/Vulkan/src/OgreVulkanProgram.cpp:45:
2023-02-19T15:19:55.4879674Z /home/conda/feedstock_root/build_artifacts/ogre-next_1676819376768/work/RenderSystems/Vulkan/include/OgreVulkanGlslangHeader.h:17:10: fatal error: glslang/Public/ShaderLang.h: No such file or directory
2023-02-19T15:19:55.4880975Z    17 | #include "glslang/Public/ShaderLang.h"
2023-02-19T15:19:55.4881591Z       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2023-02-19T15:19:55.4882089Z compilation terminated.

Probably we also need https://github.com/KhronosGroup/glslang as a dependency?

Indeed, this seems the case, see https://github.com/gazebo-forks/ogre-2.3-release/blob/35c61bb32c1b553e101cd9bacf509d2a56a9cda5/debian/control#L44 . Probably it take some more time then to package all the necessary dependencies (including the transitive one) in conda-forge .

At a first glance, also https://github.com/KhronosGroup/Vulkan-ValidationLayers may be necessary.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2023

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/ogre-next-feedstock/actions/runs/5430635127.

@traversaro
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable vulkan rendersystem
2 participants