Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for 2.3.2 #12

Closed
wants to merge 3 commits into from
Closed

Prepare for 2.3.2 #12

wants to merge 3 commits into from

Conversation

mjcarroll
Copy link
Contributor

Checklist

  • Used a personal fork of the feedstock to propose changes
  • [] Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

I have upstream-ed several of these patches. Once the 2.3.2 tag is added, this should be just about ready to go.

Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@mjcarroll
Copy link
Contributor Author

@conda-forge-admin, please rerender

@traversaro
Copy link
Contributor

Cool! Feel free to add yourself as a mantainer if you like!

@traversaro
Copy link
Contributor

traversaro commented Aug 21, 2022

Regarding the test failures, I am afraid not all patches are backport that can be removed. I wanted to eventually contribute them upstream, but it was not super clear to me how OGRECave/ogre-next#232 and OGRECave/ogre-next#259 was going, so I decided to do it later (i.e. I forgot to do it, sorry!). Some related (hidden) comments can be found in conda-forge/staged-recipes#19384 .

@traversaro
Copy link
Contributor

Looking a bit in the failures, one problem is that upstream Ogre-Next still does not install .pc files on Windows.

@mjcarroll
Copy link
Contributor Author

One problem is that upstream Ogre-Next still does not install .pc files on Windows.

Yep, I have another local patch for it. Keeping this draft until we can get it all sorted/ported.

@mjcarroll
Copy link
Contributor Author

I dumped patches from here, which I think will be slightly easier to maintain: https://github.com/gazebo-forks/ogre-next/tree/gazebo/v2-3

@talregev
Copy link

Any news?

@traversaro
Copy link
Contributor

There is no 2.3.2 release for ogre-next .

@talregev
Copy link

What version is the next release?

@traversaro
Copy link
Contributor

The latest is 2.3.1 and is packaged in conda-forge (see https://github.com/OGRECave/ogre-next/releases), the next one is 2.3.2 or some other version number > 2.3.1, probably ogre-next mantainers will decide that.

@talregev
Copy link

talregev commented Oct 31, 2023

You mean when ogre-next will be releasing this PR will become relevant?
I thought they want to change something before the release.

Thank you for your details answer.

@traversaro
Copy link
Contributor

You mean when it will be releasing on orge-next side this PR will become relevant?

Yes, this PR is just a preparation for the next release of ogre-next.

I thought they want to change something before the release.

Yes, it is possible more modifications will be necessary, that is why the PR is in draft.

@traversaro traversaro mentioned this pull request Apr 7, 2024
3 tasks
@mjcarroll mjcarroll closed this Apr 8, 2024
@mjcarroll
Copy link
Contributor Author

Replaced by #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants