Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CUDA 10.0 build #5

Closed
wants to merge 5 commits into from
Closed

Add CUDA 10.0 build #5

wants to merge 5 commits into from

Conversation

jakirkham
Copy link
Member

Builds the nvcc (shim compiler) package for CUDA 10.0.

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@jakirkham
Set default CUDA_VER to 10.0
7d2f760 
This shouldn't matter, but for simplicity set the `CUDA_VER` here to match the
version of CUDA we intend to use.
@jakirkham
Override Docker image to use the CUDA 10.0
9f84f01
@jakirkham
MNT: Re-rendered with conda-build 3.18.9, conda-smithy 3.4.7, and con…
8a5d5f7 
…da-forge-pinning 2019.09.08

Now that the Docker image has been changed to use the CUDA 10.0 image,
re-render to update the CI configuration files accordingly.
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham jakirkham changed the title Add CUDA 10.0 build WIP: Add CUDA 10.0 build Sep 17, 2019
@jakirkham
Copy link
Member Author

Oops! That should have been a draft. Marked as WIP.

@jakirkham jakirkham changed the title WIP: Add CUDA 10.0 build Add CUDA 10.0 build Sep 18, 2019
kkraus14
kkraus14 approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@kkraus14 kkraus14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

isuruf
isuruf requested changes Sep 18, 2019
View reviewed changes
Copy link
Member

@isuruf isuruf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make the two versions build from the recipe? You can use a list for docker_image

kkraus14
kkraus14 reviewed Sep 18, 2019
View reviewed changes
recipe/meta.yaml Outdated
@@ -1,5 +1,5 @@
{% set name = "nvcc" %}
{% set version = environ.get("CUDA_VER", "9.2") %}
{% set version = environ.get("CUDA_VER", "10.0") %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we default to 9.2 instead? Things are generally forward compatible but not necessarily backwards compatible.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default here is only to make the linter happy. This is always set to 10.0 by the build.

ref: conda-forge/staged-recipes#8229 (review)

@jakirkham
Copy link
Member Author

Can you make the two versions build from the recipe? You can use a list for docker_image

Yeah I'd prefer that actually, but had difficulty getting this to work when I tried it previously. Do you have a suggestion on how to implement? If so, would you be willing to throw up a quick PR? 🙂

@jakirkham jakirkham mentioned this pull request Sep 18, 2019
Closed
5 tasks
@isuruf
Copy link
Member

isuruf commented Sep 18, 2019

You need to replace version with CUDA_VER and then rerender

@jakirkham
Copy link
Member Author

@conda-forge-admin, please re-render.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like I wasn't able to push to the bld_cuda10.0 branch of jakirkham-feedstocks/nvcc-feedstock. Did you check the "Allow edits from maintainers" box?

@jakirkham
Copy link
Member Author

Sorry maybe I'm misunderstanding your suggestion, @isuruf, what still needs to be done here? If you feel comfortable making the change, would welcome it in this PR 🙂

@jakirkham
Copy link
Member Author

@conda-forge-admin, please re-render.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like I wasn't able to push to the bld_cuda10.0 branch of jakirkham-feedstocks/nvcc-feedstock. Did you check the "Allow edits from maintainers" box?

@jakirkham
Copy link
Member Author

@conda-forge-admin, please re-render.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like I wasn't able to push to the bld_cuda10.0 branch of jakirkham-feedstocks/nvcc-feedstock. Did you check the "Allow edits from maintainers" box?

@isuruf
Copy link
Member

isuruf commented Sep 19, 2019

@jakirkham, can you manually render?

@jakirkham jakirkham mentioned this pull request Sep 19, 2019
Merged
5 tasks
@jakirkham
Copy link
Member Author

Superseded by PR ( #7 ).

@jakirkham jakirkham closed this in #7 Sep 20, 2019
@jakirkham jakirkham deleted the bld_cuda10.0 branch September 20, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkraus14 kkraus14 kkraus14 approved these changes

@isuruf isuruf isuruf requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakirkham @conda-forge-linter @isuruf @kkraus14