Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numcodecs 0.13.0 #108

Merged
merged 16 commits into from
Aug 19, 2024
Merged

numcodecs 0.13.0 #108

merged 16 commits into from
Aug 19, 2024

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented Aug 12, 2024

I'm going to use this PR as an attempt to debug/build 0.13.0.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Fixes #107
Fixes #106

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@dstansby
Copy link
Contributor Author

@conda-forge-admin, please rerender

@dstansby
Copy link
Contributor Author

Okay, so 0.12.1 is working even when re-rendered. Lets try 0.13.0 now

@dstansby
Copy link
Contributor Author

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 2 commits August 12, 2024 11:46
@dstansby
Copy link
Contributor Author

@conda-forge-admin, please rerender

Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/numcodecs-feedstock/actions/runs/10351562036.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@dstansby
Copy link
Contributor Author

The linux native build is failing on

  cc -c c-blosc/internal-complibs/zstd-1.5.5/decompress/huf_decompress_amd64.S -o c-blosc/internal-complibs/zstd-1.5.5/decompress/huf_decompress_amd64.o

In a similar passing job the start of the similar command is /home/conda/feedstock_root/build_artifacts/numcodecs_1723464425174/_build_env/bin/aarch64-conda-linux-gnu-cc, which is an explicit path to the c compiler, so I think for some reason the native linux build isn't setting the path to the compiler correctly, or it isn't being picked up.

@dstansby
Copy link
Contributor Author

The build issue is unique to linux because it's only when trying to compile some assembly files that are only added on x86_64, and came in from this PR: zarr-developers/numcodecs#500.

I've patched out including those files to see if it fixes the build.

@dstansby
Copy link
Contributor Author

It did not fix the build, so it looks like these aseembly files are required.

@dstansby dstansby mentioned this pull request Aug 12, 2024
3 tasks
@dstansby dstansby force-pushed the 0.13.0 branch 2 times, most recently from e2809f4 to f2bd6bc Compare August 18, 2024 17:51
@dstansby
Copy link
Contributor Author

@conda-forge-admin, please rerender

Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/numcodecs-feedstock/actions/runs/10442615017.

@dstansby dstansby changed the title Debug 0.13.0 numcodecs 0.13.0 Aug 19, 2024
@dstansby dstansby marked this pull request as ready for review August 19, 2024 19:15
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks David! 🙏

Appreciate you spending time debugging this one 🙂

Had a few suggestions below

recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Show resolved Hide resolved
recipe/meta.yaml Show resolved Hide resolved
@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

conda-forge-webservices[bot] and others added 2 commits August 19, 2024 19:34
@dstansby
Copy link
Contributor Author

@conda-forge-admin , please re-render

@dstansby
Copy link
Contributor Author

👍 included all the suggestions (and asked for another re-render just for good measure)

Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/numcodecs-feedstock/actions/runs/10460964610.

@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/numcodecs-feedstock/actions/runs/10461735177.

@jakirkham
Copy link
Member

Thanks David! 🙏

Pushed a couple minor tweaks. Hope that is ok 🙂

Let's ship this 🚀

@jakirkham jakirkham added the automerge Merge the PR when CI passes label Aug 19, 2024
@github-actions github-actions bot merged commit c542ca4 into conda-forge:main Aug 19, 2024
20 checks passed
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants