Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Try with 0.59.0rc1 and llvmlite 0.42.0rc1 from gmarkall channel #131

Closed
wants to merge 6 commits into from

Conversation

gmarkall
Copy link
Contributor

Testing 0.59 on conda-forge before we tag the release, to avoid issues seen previously where we only discovered problems once the conda-forge package started building

MNT: Re-rendered with conda-build 3.26.0, conda-smithy 3.30.4, and conda-forge-pinning 2024.01.23.16.47.43
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

MNT: Re-rendered with conda-build 3.26.0, conda-smithy 3.30.4, and conda-forge-pinning 2024.01.23.16.47.43
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Graham! 🙏

Added a few suggestions below to pick up the llvmlite RC packages in this PR

Also include notes on how to configure this PR to publish RCs

Would make sure to re-render after including any of these changes (as they make changes to .ci_support files that configure the various builds)

Please let me know if you have any questions 🙂


package:
name: numba
version: {{ version }}

source:
url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz
# url: https://github.com/numba/numba/archive/{{ version }}.tar.gz
url: https://github.com/numba/numba/archive/refs/tags/{{ version }}.tar.gz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url: https://github.com/numba/numba/archive/refs/tags/{{ version }}.tar.gz
url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz
# url: https://github.com/numba/numba/archive/{{ version }}.tar.gz

{% set version = "0.58.1" %}
{% set sha256 = "487ded0633efccd9ca3a46364b40006dbdaca0f95e99b8b83e778d1195ebcbaa" %}
{% set version = "0.59.0rc1" %}
{% set sha256 = "6477c7e4ac128697b1182298da8e45ef74f74417ca6bc81f66c1f479e4773884" %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{% set sha256 = "6477c7e4ac128697b1182298da8e45ef74f74417ca6bc81f66c1f479e4773884" %}
{% set sha256 = "c8aab21a34081f0c659890d9e49fda42e537d782f6a90c046280c6eae2069d78" %}

@@ -0,0 +1,2 @@
channel_sources:
- gmarkall,conda-forge
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- gmarkall,conda-forge
- conda-forge/label/llvmlite_rc,conda-forge
channel_targets:
- conda-forge numba_rc

@jakirkham
Copy link
Member

Also the linux_ppc64le & linux_aarch64 testing here has been in a rocky place. Some history in issue ( #102 )

@@ -39,7 +38,7 @@ requirements:
- python
- pip
- setuptools
- llvmlite 0.41.*
- llvmlite 0.42.0rc1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this would still work (even with an RC). Though could make sense to keep it tighter if things change significantly between RCs or the final release

Suggested change
- llvmlite 0.42.0rc1
- llvmlite 0.42.*

@jakirkham
Copy link
Member

Thanks again Graham! 🙏

Looks like 0.59.0 shipped without a hitch ( #132 ). The llvmlite version 0.42.0 release was similarly smooth ( conda-forge/llvmlite-feedstock#82 )

Thanks again for taking the time to test these out (and workout any issues) before the release 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants