Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add noop legacy output for nteract-scrapbook #6

Merged
merged 2 commits into from
Feb 27, 2021

Conversation

bollwyvl
Copy link
Contributor

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Notes:

  • this adds multiple outputs, with an nteract-scrapbook that exists only to depend on scrapbook at the exact version (though build numbers won't be consulted)
  • @MSeal if this is a terrible idea, please let me know... dagster might be the only downstream, so maybe this isn't a big deal, but renaming is always awkward

@bollwyvl bollwyvl requested a review from MSeal as a code owner February 27, 2021 17:20
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Copy link
Contributor

@MSeal MSeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm actually on second thought -- what's the motivation here for the change?

@bollwyvl
Copy link
Contributor Author

conda-forge/dagster-feedstock#106

(the reason i am helping maintain this package in the first place 🎉 )

@bollwyvl
Copy link
Contributor Author

Basically, I want a smooth, tested upgrade path to the 0.5 line for dagster installs

@MSeal
Copy link
Contributor

MSeal commented Feb 27, 2021

More specifically why make a hollow reference, over changing the downstream to use the new name? We version separated the package name change so libraries could swap over to the new minor version without disrupting pulls from the old version name.

Oh did I just mess up the name change the first time around on the feedstock? Should we just drop the nteract-scrapbook output? Apologies for catching up on how feedstocks work again...

@bollwyvl
Copy link
Contributor Author

changing the downstream to use the new name?

I haven't dug into the complexity behind what's running under the hood papermill versions, etc. But specifically, in my case, with a downstream like dagster which needs to work correctly next to airflow + graphl + grpc + dog, environments can become unsolveable (e.g. that shiny new m1 doesn't have <old version> on <old python> of <transient dependency>). I'd rather find out about that now, while trying to package, rather than when someone can't install the downstream with "fancy new feature x," because they are stuck on grpcio X.Y.Z

@bollwyvl
Copy link
Contributor Author

mess up the name change the first time around on the feedstock?

Nope, what you did is exactly right, it just means that no downstreams will ever pull new versions.... and installing both, next to each other, would break the world.

@MSeal
Copy link
Contributor

MSeal commented Feb 27, 2021

If it makes the world simpler for you, I'm OK merging. I do dislike dual package name patterns because it's confusing and upstream packages should really be able to control their versions and naming without indefinitely maintaining older patterns. But I'm less familiar with convention here with conda feedstocks so I'll defer to you. Just wanted to bring it up as what I'd see as an anti-pattern and maintenance concern down the road.

@bollwyvl bollwyvl merged commit d514cff into conda-forge:master Feb 27, 2021
@bollwyvl
Copy link
Contributor Author

Indeed, my world is simpler now.

bollwyvl added a commit to bollwyvl/nteract-scrapbook-feedstock that referenced this pull request Mar 8, 2021
@bollwyvl bollwyvl mentioned this pull request Mar 8, 2021
5 tasks
bollwyvl added a commit that referenced this pull request Mar 8, 2021
revert #6, remove nteract-scrapbook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants