-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add noop legacy output for nteract-scrapbook #6
Conversation
…da-forge-pinning 2021.02.26.15.36.03
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm actually on second thought -- what's the motivation here for the change?
conda-forge/dagster-feedstock#106 (the reason i am helping maintain this package in the first place 🎉 ) |
Basically, I want a smooth, tested upgrade path to the 0.5 line for dagster installs |
More specifically why make a hollow reference, over changing the downstream to use the new name? We version separated the package name change so libraries could swap over to the new minor version without disrupting pulls from the old version name. Oh did I just mess up the name change the first time around on the feedstock? Should we just drop the |
I haven't dug into the complexity behind what's running under the hood |
Nope, what you did is exactly right, it just means that no downstreams will ever pull new versions.... and installing both, next to each other, would break the world. |
If it makes the world simpler for you, I'm OK merging. I do dislike dual package name patterns because it's confusing and upstream packages should really be able to control their versions and naming without indefinitely maintaining older patterns. But I'm less familiar with convention here with conda feedstocks so I'll defer to you. Just wanted to bring it up as what I'd see as an anti-pattern and maintenance concern down the road. |
Indeed, my world is simpler now. |
revert #6, remove nteract-scrapbook
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)Notes:
outputs
, with annteract-scrapbook
that exists only to depend onscrapbook
at the exact version (though build numbers won't be consulted)