Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable OSX arm64 - attempt 2 #75

Merged
merged 32 commits into from
Mar 11, 2022
Merged

Conversation

Tobias-Fischer
Copy link
Contributor

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@Tobias-Fischer Tobias-Fischer mentioned this pull request Feb 15, 2022
5 tasks
@Tobias-Fischer
Copy link
Contributor Author

All builds except for Windows now succeed.

@conda-forge/help-osx-arm64 @conda-forge/mumps @traversaro - could you please have a look?

@traversaro
Copy link
Contributor

Random guess: set FC=flang?

@traversaro
Copy link
Contributor

Actually I installed locally and even if I installed the same version used in https://github.com/conda-forge/mumps-feedstock/runs/3253545563 (last successful build) I do not have any flang.exe installed, just flang1.exe and flang2.exe, not sure why.

@traversaro
Copy link
Contributor

Actually I installed locally and even if I installed the same version used in https://github.com/conda-forge/mumps-feedstock/runs/3253545563 (last successful build) I do not have any flang.exe installed, just flang1.exe and flang2.exe, not sure why.

We could try to pass flang1 or flang2 as compiled, but it is a shot in the dark. Perhaps @conda-forge/flang may know something more.

@isuruf
Copy link
Member

isuruf commented Mar 10, 2022

@traversaro
Copy link
Contributor

conda-forge/conda-forge-repodata-patches-feedstock#226 should fix it

Great, thanks!

@traversaro
Copy link
Contributor

traversaro commented Mar 10, 2022

Actually I installed locally and even if I installed the same version used in https://github.com/conda-forge/mumps-feedstock/runs/3253545563 (last successful build) I do not have any flang.exe installed, just flang1.exe and flang2.exe, not sure why.

An explanation is given in mamba-org/mamba#897 (comment) . TL;DR: It is related to a difference in how conda and mamba resolve packages, and now mamba is used by default.

@traversaro traversaro mentioned this pull request Mar 10, 2022
5 tasks
@Tobias-Fischer
Copy link
Contributor Author

@conda-forge/mumps - this is ready for review. The windows build fail should be resolved by a restart of the CI in a few hours.

@Tobias-Fischer
Copy link
Contributor Author

Thanks for the hints @traversaro @isuruf !

@traversaro
Copy link
Contributor

@conda-forge-admin, please restart ci

@traversaro
Copy link
Contributor

@conda-forge/mumps - this is ready for review. The windows build fail should be resolved by a restart of the CI in a few hours.

The Windows build is now ok.

@dalcinl
Copy link
Contributor

dalcinl commented Mar 10, 2022

@Tobias-Fischer @traversaro Should I merge?

@traversaro
Copy link
Contributor

@Tobias-Fischer @traversaro Should I merge?

Yes, thanks!

@Tobias-Fischer
Copy link
Contributor Author

Yes please :)

@isuruf
Copy link
Member

isuruf commented Mar 10, 2022

@conda-forge-admin, rerender

@dalcinl
Copy link
Contributor

dalcinl commented Mar 10, 2022

@isuruf Please click the merge button if you are done. Maybe you should also close #73?

@Tobias-Fischer
Copy link
Contributor Author

I think we can merge this @dalcinl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants