v1.20241002 #50

charman2 · 2024-10-02T20:31:31Z

Checklist

Used a personal fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
Ensured the license file is being packaged.

TL;DR: The way we build against numpy has changed as of numpy 2.0. This bot PR has updated the recipe to account for the changes (see below for details). The numpy 2.0 package itself is currently only available from a special release channel (`conda-forge/label/numpy_rc`) and will not be available on the main `conda-forge` channel until the release of numpy 2.0 GA. The biggest change is that we no longer need to use the oldest available numpy version at build time in order to support old numpy version at runtime - numpy will by default use a compatible ABI for the oldest still-supported numpy versions. Additionally, we no longer need to use `{{ pin_compatible("numpy") }}` as a run requirement - this has been handled for more than two years now by a run-export on the numpy package itself. The migrator will therefore remove any occurrences of this. However, by default, building against numpy 2.0 will assume that the package is compatible with numpy 2.0, which is not necessarily the case. You should check that the upstream package explicitly supports numpy 2.0, otherwise you need to add a `- numpy <2.0dev0` run requirement until that happens (check numpy issue 26191 for an overview of the most important packages). Note that the numpy release candidate promises to be ABI-compatible with the final 2.0 release. This means that building against 2.0.0rc1 produces packages that can be published to our main channels. If you already want to use the numpy 2.0 release candidate yourself, you can do ``` conda config --add channels conda-forge/label/numpy_rc ``` or add this channel to your `.condarc` file directly. ### To-Dos: * [ ] Match run-requirements for numpy (i.e. check upstream `pyproject.toml` or however the project specifies numpy compatibility) * If upstream is not yet compatible with numpy 2.0, add `numpy <2.0dev0` upper bound under `run:`. * If upstream is already compatible with numpy 2.0, nothing else should be necessary in most cases. * If upstream requires a minimum numpy version newer than 1.19, you can add `numpy >=x.y` under `run:`. * [ ] Remove any remaining occurrences of `{{ pin_compatible("numpy") }}` that the bot may have missed. PS. If the build does not compile anymore, this is almost certainly a sign that the upstream project is not yet ready for numpy 2.0; do not close this PR until a version compatible with numpy 2.0 has been released upstream and on this feedstock (in the meantime, you can keep the bot from reopening this PR in case of git conflicts by marking it as a draft).

…nda-forge-pinning 2024.06.15.21.41.23

charman2 · 2024-10-02T20:31:45Z

@ conda-forge-admin, please rerender

charman2 · 2024-10-02T20:33:02Z

@conda-forge-admin, please rerender

conda-forge-admin · 2024-10-02T20:33:22Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [29, 30, 31, 37]

conda-forge-admin · 2024-10-02T20:35:48Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the GitHub actions workflow below for more details. You can also ping conda-forge/core for further assistance or you can try rerendering locally.

The following suggestions might help debug any issues:

Is the recipe/{meta.yaml,recipe.yaml} file valid?
If there is a recipe/conda-build-config.yaml file in the feedstock make sure that it is compatible with the current global pinnnings.
Is the fork used for this PR on an organization or user GitHub account? Automated rerendering via the webservices admin bot only works for user GitHub accounts.

_{This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11151186572.}

charman2 · 2024-10-02T20:39:00Z

@conda-forge-admin, please rerender

conda-forge-admin · 2024-10-02T20:41:38Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the GitHub actions workflow below for more details. You can also ping conda-forge/core for further assistance or you can try rerendering locally.

The following suggestions might help debug any issues:

Is the recipe/{meta.yaml,recipe.yaml} file valid?
If there is a recipe/conda-build-config.yaml file in the feedstock make sure that it is compatible with the current global pinnnings.
Is the fork used for this PR on an organization or user GitHub account? Automated rerendering via the webservices admin bot only works for user GitHub accounts.

_{This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11151267366.}

charman2 · 2024-10-02T20:46:27Z

@conda-forge-admin, please rerender

conda-forge-admin · 2024-10-02T20:47:55Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

conda-forge-admin · 2024-10-02T20:49:23Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the GitHub actions workflow below for more details. You can also ping conda-forge/core for further assistance or you can try rerendering locally.

The following suggestions might help debug any issues:

Is the recipe/{meta.yaml,recipe.yaml} file valid?
If there is a recipe/conda-build-config.yaml file in the feedstock make sure that it is compatible with the current global pinnnings.
Is the fork used for this PR on an organization or user GitHub account? Automated rerendering via the webservices admin bot only works for user GitHub accounts.

_{This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11151362628.}

jakirkham

Thanks Ciaran! 🙏

Added a few suggestions below

In particular think the NumPy pins may be causing us issues in getting CI to work

recipe/meta.yaml

jakirkham · 2024-10-02T23:17:47Z

recipe/meta.yaml

  host:
    - python
-    - setuptools


Just to confirm, there is no longer any use of setuptools in the build?

It looks like CI is running into errors not finding distutils, which setuptools vendors

Can we try adding this back?

No harm in trying, but it shouldn't need it. The main fix in the new version of the package was to migrate from setuptools to meson, since distutils is deprecated

For clarity this is the traceback from CI:

Traceback (most recent call last): File "/home/conda/feedstock_root/build_artifacts/mesas_1727984139908/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/bin/f2py", line 10, in <module> sys.exit(main()) File "/home/conda/feedstock_root/build_artifacts/mesas_1727984139908/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.10/site-packages/numpy/f2py/f2py2e.py", line 691, in main run_compile() File "/home/conda/feedstock_root/build_artifacts/mesas_1727984139908/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.10/site-packages/numpy/f2py/f2py2e.py", line 619, in run_compile from numpy.distutils.system_info import get_info File "/home/conda/feedstock_root/build_artifacts/mesas_1727984139908/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.10/site-packages/numpy/distutils/system_info.py", line 196, in <module> from numpy.distutils.command.config import config as cmd_config File "/home/conda/feedstock_root/build_artifacts/mesas_1727984139908/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.10/site-packages/numpy/distutils/command/config.py", line 19, in <module> from numpy.distutils.mingw32ccompiler import generate_manifest File "/home/conda/feedstock_root/build_artifacts/mesas_1727984139908/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.10/site-packages/numpy/distutils/mingw32ccompiler.py", line 28, in <module> from distutils.msvccompiler import get_build_version as get_build_msvc_version ModuleNotFoundError: No module named 'distutils.msvccompiler'

Looks like this issue traces back to f2py ( numpy/numpy#24838 ), which was fixed in NumPy 2 ( numpy/numpy#25123 )

Have merged the NumPy 2 migrator from PR ( #49 ) into this PR. Let's see if that helps

In some jobs this appears to be fixed! 🎉 However there are new errors (noted below) 😞 Please take a look at the comments below

We still see this error in a few jobs. So let's keep this thread open

Though setuptools isn't helping in any case. So think we can go ahead and drop it again

recipe/meta.yaml

Co-authored-by: jakirkham <[email protected]>

jakirkham · 2024-10-03T19:30:44Z

@conda-forge-admin , please re-render

…nda-forge-pinning 2024.10.03.16.49.14

…nda-forge-pinning 2024.10.03.22.00.47

recipe/meta.yaml

…master

jakirkham · 2024-10-04T00:28:03Z

In a few CI jobs (like this one), we are seeing this error

import: 'mesas'
import: 'mesas.sas.solve'
Traceback (most recent call last):
  File "/Users/runner/miniforge3/conda-bld/mesas_1728001177938/test_tmp/run_test.py", line 5, in <module>
    import mesas.sas.solve
ModuleNotFoundError: No module named 'mesas.sas.solve'

Do we need to update these tests for this version?

mesas-feedstock/recipe/meta.yaml

Lines 39 to 42 in a105756

    
           test: 
        
             imports: 
        
               - mesas 
        
               - mesas.sas.solve

jakirkham · 2024-10-04T00:32:26Z

The macOS ARM builds, which use cross-compilation, are having issues running. Have seen similar issues with Meson before. Think we need to adapt the build logic here for them

https://github.com/conda-forge/pywavelets-feedstock/blob/2bc11d63d4c63ca91f31a3247f8282b2bfae0e76/recipe/meta.yaml#L17-L22

Note this approach uses python-build, which we would need to add to requirements/host

recipe/meta.yaml

jakirkham · 2024-10-04T00:38:02Z

Windows Fortran builds have this error

  [6/6] Linking target mesas_solve.cp312-win_amd64.pyd
  FAILED: mesas_solve.cp312-win_amd64.pyd
  "link"  /MACHINE:x64 /OUT:mesas_solve.cp312-win_amd64.pyd mesas_solve.cp312-win_amd64.pyd.p/solve.f90.obj mesas_solve.cp312-win_amd64.pyd.p/mesas_solvemodule.c.obj mesas_solve.cp312-win_amd64.pyd.p/mesas_solve-f2pywrappers2.f90.obj mesas_solve.cp312-win_amd64.pyd.p/7c6f89aff64b5d6ae9af36457a578bcaa22407a2_.._.._f2py_src_fortranobject.c.obj "/LIBPATH:D:/bld/mesas_1728001287970/_build_env/Library/mingw-w64/lib/gcc/x86_64-w64-mingw32/5.3.0" "/LIBPATH:D:/bld/mesas_1728001287970/_build_env/Library/mingw-w64/bin/../lib/gcc/x86_64-w64-mingw32/5.3.0" "/LIBPATH:D:/bld/mesas_1728001287970/_build_env/Library/mingw-w64/lib/gcc" "/LIBPATH:D:/bld/mesas_1728001287970/_build_env/Library/mingw-w64/bin/../lib/gcc" "/LIBPATH:D:/bld/mesas_1728001287970/_build_env/Library/mingw-w64/x86_64-w64-mingw32/lib" "/LIBPATH:D:/bld/mesas_1728001287970/_build_env/Library/mingw-w64/bin/../lib/gcc/x86_64-w64-mingw32/5.3.0/../../../../x86_64-w64-mingw32/lib/../lib" "/LIBPATH:D:/bld/mesas_1728001287970/_build_env/Library/mingw-w64/lib" "/LIBPATH:D:/bld/mesas_1728001287970/_build_env/Library/mingw-w64/bin/../lib/gcc/x86_64-w64-mingw32/5.3.0/../../../../lib" "/LIBPATH:D:/bld/mesas_1728001287970/_build_env/Library/mingw-w64/bin/../lib/gcc/x86_64-w64-mingw32/5.3.0/../../../../x86_64-w64-mingw32/lib" "/LIBPATH:D:/bld/mesas_1728001287970/_build_env/Library/mingw-w64/bin/../lib/gcc/x86_64-w64-mingw32/5.3.0/../../.." "/release" "/nologo" "/OPT:REF" "/DLL" "/IMPLIB:mesas_solve.cp312-win_amd64.lib" "D:\bld\mesas_1728001287970\_h_env\libs\python312.lib" "quadmath.lib" "kernel32.lib" "user32.lib" "gdi32.lib" "winspool.lib" "shell32.lib" "ole32.lib" "oleaut32.lib" "uuid.lib" "comdlg32.lib" "advapi32.lib" "gfortran.lib"
  LINK : fatal error LNK1181: cannot open input file 'quadmath.lib'

This suggests either the library search path needs a fix or quadmath is missing

More likely it is the former, but let's try to solve a few of the other issues before digging into this one

Co-authored-by: jakirkham <[email protected]>

charman2 · 2024-10-04T15:13:31Z

mesas.sas.solve is the fortran number-crunching code that the python is wrapping. The import test should work. If it is being built but the test is failing I guess the extension is being put in the wrong place?

I'll try that script for the mac ARM builds

No idea what the deal is with the quadmath library

Again, I appreciate the help. I'm starting to tear my hair out!

charman2 · 2024-10-04T15:30:47Z

My attempt at the script failed with

conda_build.exceptions.CondaBuildException: Found a build.sh script and a build/script section inside meta.yaml. Either remove the build.sh script or remove the build/script section in meta.yaml.

across the board

jakirkham · 2024-10-07T18:11:48Z

Yes this would need to either...

...go in the existing build.sh and bld.bat scripts
...or those scripts would need to be removed and the scripts section used instead

regro-cf-autotick-bot and others added 3 commits June 16, 2024 02:31

MNT: Re-rendered with conda-build 24.5.1, conda-smithy 3.36.2, and co…

7c6c078

…nda-forge-pinning 2024.06.15.21.41.23

no message

0b2c031

lint

d4b88be

Ciaran Harman added 2 commits October 2, 2024 16:42

more lint

e55244a

liiint

b9241f3

Ciaran Harman added 2 commits October 2, 2024 16:50

gah

13c26e4

bleaurgh

9c3c2a6

jakirkham reviewed Oct 2, 2024

View reviewed changes

charman2 and others added 8 commits October 3, 2024 10:01

Update recipe/meta.yaml

fea1b87

Co-authored-by: jakirkham <[email protected]>

Update recipe/meta.yaml

341ca6e

Co-authored-by: jakirkham <[email protected]>

Update recipe/meta.yaml

9740b78

Co-authored-by: jakirkham <[email protected]>

Update recipe/meta.yaml

2b07f5d

Co-authored-by: jakirkham <[email protected]>

Update recipe/meta.yaml

e69726d

Co-authored-by: jakirkham <[email protected]>

Update recipe/meta.yaml

c9be102

Co-authored-by: jakirkham <[email protected]>

Update meta.yaml

fa014ee

Update meta.yaml

73a0466

conda-forge-webservices[bot] and others added 3 commits October 3, 2024 19:33

MNT: Re-rendered with conda-build 24.9.0, conda-smithy 3.41.1, and co…

3cb7ba2

…nda-forge-pinning 2024.10.03.16.49.14

Update meta.yaml

03ee3cc

MNT: Re-rendered with conda-build 24.9.0, conda-smithy 3.41.1, and co…

7d4e9f2

…nda-forge-pinning 2024.10.03.22.00.47

Drop extra blank line

9b77e31

jakirkham reviewed Oct 4, 2024

View reviewed changes

recipe/meta.yaml Outdated Show resolved Hide resolved

jakirkham added 2 commits October 3, 2024 17:13

Reset build/number to 0

83398d0

Merge regro-cf-autotick-bot/rebuild-numpy2-0-1_h7e7de2 into charman2/…

ce7a891

…master

jakirkham reviewed Oct 4, 2024

View reviewed changes

recipe/meta.yaml Outdated Show resolved Hide resolved

charman2 and others added 2 commits October 4, 2024 10:57

Update recipe/meta.yaml

1b8260b

Co-authored-by: jakirkham <[email protected]>

Update meta.yaml (testing script)

0b33570

charman2 added 2 commits October 4, 2024 11:31

Update meta.yaml (undo script)

3b6e65c

Update meta.yaml

07093d1

Ciaran Harman and others added 3 commits October 7, 2024 14:48

update sha

7ae4337

Merge branch 'master' of https://github.com/charman2/mesas-feedstock

5484a85

Update meta.yaml

5e2dd6c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v1.20241002 #50

v1.20241002 #50

charman2 commented Oct 2, 2024

charman2 commented Oct 2, 2024

charman2 commented Oct 2, 2024

conda-forge-admin commented Oct 2, 2024 •

edited

Loading

conda-forge-admin commented Oct 2, 2024

charman2 commented Oct 2, 2024

conda-forge-admin commented Oct 2, 2024

charman2 commented Oct 2, 2024

conda-forge-admin commented Oct 2, 2024

conda-forge-admin commented Oct 2, 2024

jakirkham left a comment

jakirkham Oct 2, 2024

charman2 Oct 3, 2024

jakirkham Oct 3, 2024

charman2 Oct 3, 2024

jakirkham Oct 3, 2024

jakirkham Oct 4, 2024

jakirkham Oct 4, 2024

jakirkham Oct 4, 2024

jakirkham commented Oct 3, 2024

jakirkham commented Oct 4, 2024

jakirkham commented Oct 4, 2024

jakirkham commented Oct 4, 2024

charman2 commented Oct 4, 2024

charman2 commented Oct 4, 2024

jakirkham commented Oct 7, 2024

v1.20241002 #50

Are you sure you want to change the base?

v1.20241002 #50

Conversation

charman2 commented Oct 2, 2024

charman2 commented Oct 2, 2024

charman2 commented Oct 2, 2024

conda-forge-admin commented Oct 2, 2024 • edited Loading

conda-forge-admin commented Oct 2, 2024

charman2 commented Oct 2, 2024

conda-forge-admin commented Oct 2, 2024

charman2 commented Oct 2, 2024

conda-forge-admin commented Oct 2, 2024

conda-forge-admin commented Oct 2, 2024

jakirkham left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jakirkham commented Oct 3, 2024

jakirkham commented Oct 4, 2024

jakirkham commented Oct 4, 2024

jakirkham commented Oct 4, 2024

charman2 commented Oct 4, 2024

charman2 commented Oct 4, 2024

jakirkham commented Oct 7, 2024

conda-forge-admin commented Oct 2, 2024 •

edited

Loading