Add missing numpy host dependency and constrain pybind11 < 2.12.0 for ABI Windows problem #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something that I overlooked when packaging Python bindings to C++ libraries that wrap eigen vector or matrices via the
pybind/eigen.h
header is that those bindings depends on numpy ABI (via the include sequencepybind/eigen.h
-->pybind/eigen/matrix.h
-->pybind/numpy.h
).We never noticed this as for a long time numpy 1 was just ABI stable, but now that numpy 2 came out, we are seeing problems (see segfaults in conda-forge/bipedal-locomotion-framework-feedstock#69 and conda-forge/bipedal-locomotion-framework-feedstock#72).
For manifpy and
bipedal-locomotion-framework
python users: in a nutshell if we see something strange (i.e. segfaults) in conda environments with old versions of manifpy and bipedal-locomotion-framework, a easy workaround is just to pinnumpy<2
. A cleaner solution would be to prepare a repodata patch (see https://github.com/conda-forge/conda-forge-repodata-patches-feedstock), but as that takes time to do it properly I would prefer to avoid it unless we actually see the need to do it.The pybind11 constrain is instead necessary for conda-forge/pybind11-feedstock#94 (comment) .
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)