Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build shared libraries as well #66

Merged
merged 19 commits into from
Aug 17, 2019
Merged

Build shared libraries as well #66

merged 19 commits into from
Aug 17, 2019

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Apr 24, 2019

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@isuruf
Copy link
Member Author

isuruf commented Apr 24, 2019

@conda-forge-admin, rerender

@isuruf isuruf changed the title Build shared libraries as well [WIP] Build shared libraries as well Apr 24, 2019
@isuruf
Copy link
Member Author

isuruf commented Aug 9, 2019

@conda-forge-admin, rerender

@isuruf isuruf requested a review from pitrou as a code owner August 9, 2019 00:05
@mingwandroid
Copy link
Contributor

Do you want to use these for the compilers too? That could be awesome, currently installing clang on macOS takes ages since we statically link them (and bundle all the static libs).

@isuruf
Copy link
Member Author

isuruf commented Aug 9, 2019

Sure. rebuilding clangdev using this package would be enough.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@isuruf isuruf changed the title [WIP] Build shared libraries as well Build shared libraries as well Aug 16, 2019
@isuruf
Copy link
Member Author

isuruf commented Aug 17, 2019

I'm going to merge this as it's backwards compatible and will work on 8.0.1

@isuruf isuruf merged commit 9dca44b into conda-forge:master Aug 17, 2019
@isuruf isuruf deleted the shared branch August 17, 2019 21:49
@h-vetinari h-vetinari mentioned this pull request May 16, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants