Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for CUDA 12 w/arch + Windows support #13

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update cuda120.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


Here are some more details about this specific migrator:

The transition to CUDA 12 SDK includes new packages for all CUDA libraries and build tools. Notably, the cudatoolkit package no longer exists, and packages should depend directly on the specific CUDA libraries (libcublas, libcusolver, etc) as needed. For an in-depth overview of the changes and to report problems see this issue. Please feel free to raise any issues encountered there. Thank you! 🙏


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/6891353581, please use this URL for debugging.

The transition to CUDA 12 SDK includes new packages for all CUDA libraries and
build tools. Notably, the cudatoolkit package no longer exists, and packages
should depend directly on the specific CUDA libraries (libcublas, libcusolver,
etc) as needed. For an in-depth overview of the changes and to report problems
[see this issue]( conda-forge/conda-forge.github.io#1963 ).
Please feel free to raise any issues encountered there. Thank you! 🙏
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@carterbox
Copy link
Member

Build is failing because the windows build scripts needs logic to change the target CUDA archs per CUDA toolkit version.

@carterbox carterbox self-assigned this Nov 16, 2023
@carterbox carterbox added the automerge Merge the PR when CI passes label Nov 16, 2023
@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Nov 16, 2023
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@carterbox
Copy link
Member

The link checker seems to think that libcudart is missing from the run requirements on Windows. The Windows cudart run export is missing maybe?

@jakirkham
Copy link
Member

It should be there

We did spot a conda-build warning here ( conda-forge/cuda-cudart-feedstock#13 ). Though hadn't settled on a fix. The library is provided for. So it is really a question of what is the right way to ensure conda-build doesn't raise the warning

Are we turning that warning into an error in this feedstock?

@carterbox
Copy link
Member

Are we turning that warning into an error in this feedstock?

Yes. The warning is promoted to an error somehow, so the build fails.

@jakirkham
Copy link
Member

jakirkham commented Nov 16, 2023

Looks like conda-forge.yml sets conda_build's error_overlinking , which would cause this behavior:

conda_build:
error_overlinking: true

We could turn that off

Alternatively could add build/overlinking_ignore_patterns to ignore specific instances

@jakirkham
Copy link
Member

@carterbox would be curious to hear your thoughts on the options above 🙂

@carterbox
Copy link
Member

I'm reluctant to disable overlinking warnings/errors. I'd rather wait until the cudart packages for Windows are adapted to account for the Windows-platform's different capabilities/behavior or the missing symbolic link is added to the cudart package.

I'm not in a hurry to merge this PR since pytorch hasn't been built for Windows in quite some time, and this package is already build for every other plaform that supports CUDA 12.

@jakirkham
Copy link
Member

Would just note that what conda-build is complaining about is a layer of indirection done to be compatible with the cross-compilation structure

The library is there. It is just within cuda-cudart_win-64, which cuda-cudart depends on. As opposed to in cuda-cudart directly

@jakirkham
Copy link
Member

Think the other benefit in completing libmagma would be to allow the migrator to handle all the PyTorch dependencies, which are still waiting for Linux CUDA 12 builds

Maybe if we are not comfortable with one of the options above and merging, we should consider closing this PR and revisiting at a later time

@carterbox
Copy link
Member

@conda-forge-admin, please rerender

@carterbox carterbox added the automerge Merge the PR when CI passes label Nov 22, 2023
@carterbox carterbox added automerge Merge the PR when CI passes and removed automerge Merge the PR when CI passes labels Nov 22, 2023
@github-actions github-actions bot merged commit 6b19803 into conda-forge:main Nov 23, 2023
13 checks passed
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-cuda120-0-3_hbe1400 branch November 23, 2023 02:40
@jakirkham
Copy link
Member

Thanks Daniel! 🙏

Will follow up when we have a better resolution to issue: conda-forge/cuda-cudart-feedstock#13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants