Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for libprotobuf319 #63

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update libprotobuf319.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

This package has the following downstream children:

And potentially more.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot.
The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.
Finally, feel free to drop us a line if there are any issues!
This PR was generated by https://github.com/regro/autotick-bot/actions/runs/1559585102, please use this URL for debugging

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@Tobias-Fischer Tobias-Fischer added the automerge Merge the PR when CI passes label Dec 11, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 11, 2021

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@Tobias-Fischer
Copy link
Contributor

Hmm these rebuilds on cross-compile platforms fail with:

/home/conda/feedstock_root/build_artifacts/libignition-msgs8_1639258447517/_build_env/bin/../lib/gcc/x86_64-conda-linux-gnu/9.4.0/../../../../x86_64-conda-linux-gnu/bin/ld: /home/conda/feedstock_root/build_artifacts/libignition-msgs8_1639258447517/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/lib/libtinyxml2.so: error adding symbols: file in wrong format
collect2: error: ld returned 1 exit status

It seems like it finds the host tinyxml2 rather than the build tinyxml2 in the first build step.

I'm not sure how to solve this - any ideas @traversaro?

@traversaro
Copy link
Contributor

I'm not sure how to solve this - any ideas @traversaro?

It seems that pkg-config still finds before the host packages instead of the build one in the first build step, and unfortunatly the ignition's FindTINYXML2 uses pkg-config, see gazebosim/gz-cmake#70 . Not sure why this happened in the past, perhaps some change in CMake (just an hypothesis). I will try to check some way of forcing the build's .pc to be find first in this case.

@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Dec 12, 2021
@traversaro
Copy link
Contributor

Changing the value of the PKG_CONFIG_PATH env variable with:

export PKG_CONFIG_PATH=${PKG_CONFIG_PATH//$PREFIX/$BUILD_PREFIX}

seems indeed to work.

Now the build work, but there are some tests related to the ign command tool that are failing:

2021-12-12T19:16:03.1477651Z     Start 5: UNIT_ign_TEST
2021-12-12T19:16:04.1982924Z 5/6 Test #5: UNIT_ign_TEST ....................***Failed    1.05 sec
2021-12-12T19:16:04.1984223Z [==========] Running 4 tests from 1 test case.
2021-12-12T19:16:04.1986493Z [----------] Global test environment set-up.
2021-12-12T19:16:04.1987521Z [----------] 4 tests from CmdLine
2021-12-12T19:16:04.1989200Z [ RUN      ] CmdLine.Versions
2021-12-12T19:16:04.1992295Z [       OK ] CmdLine.Versions (277 ms)
2021-12-12T19:16:04.1994841Z [ RUN      ] CmdLine.Help
2021-12-12T19:16:04.1997707Z [       OK ] CmdLine.Help (400 ms)
2021-12-12T19:16:04.2000305Z [ RUN      ] CmdLine.MsgList
2021-12-12T19:16:04.2003544Z $SRC_DIR/tools/ign_TEST.cc:79: Failure
2021-12-12T19:16:04.2006415Z Expected: (std::string::npos) != (output.find("ign_msgs.WorldControl")), actual: 18446744073709551615 vs 18446744073709551615
2021-12-12T19:16:04.2009703Z Library error: [$SRC_DIR/build/lib/libignition-msgs8.so.8.1.0] not found.
2021-12-12T19:16:04.2021865Z 
2021-12-12T19:16:04.2022928Z [  FAILED  ] CmdLine.MsgList (152 ms)
2021-12-12T19:16:04.2023553Z [ RUN      ] CmdLine.MsgInfo
2021-12-12T19:16:04.2023902Z $SRC_DIR/tools/ign_TEST.cc:88: Failure
2021-12-12T19:16:04.2024950Z Expected: (std::string::npos) != (output.find("message WorldControl {")), actual: 18446744073709551615 vs 18446744073709551615
2021-12-12T19:16:04.2025958Z Library error: [$SRC_DIR/build/lib/libignition-msgs8.so.8.1.0] not found.
2021-12-12T19:16:04.2026259Z 
2021-12-12T19:16:04.2026561Z [  FAILED  ] CmdLine.MsgInfo (127 ms)
2021-12-12T19:16:04.2027147Z [----------] 4 tests from CmdLine (957 ms total)
2021-12-12T19:16:04.2027379Z 
2021-12-12T19:16:04.2027894Z [----------] Global test environment tear-down
2021-12-12T19:16:04.2028574Z [==========] 4 tests from 1 test case ran. (965 ms total)
2021-12-12T19:16:04.2028962Z [  PASSED  ] 2 tests.
2021-12-12T19:16:04.2029314Z [  FAILED  ] 2 tests, listed below:
2021-12-12T19:16:04.2029661Z [  FAILED  ] CmdLine.MsgList
2021-12-12T19:16:04.2029994Z [  FAILED  ] CmdLine.MsgInfo
2021-12-12T19:16:04.2030170Z 
2021-12-12T19:16:04.2030420Z  2 FAILED TESTS
2021-12-12T19:16:04.2030591Z 

@traversaro
Copy link
Contributor

Now the build work, but there are some tests related to the ign command tool that are failing:

Probably this is some kind of strange interaction of fork used in UNIT_ign_TEST and the qemu-based crosscompiler (i.e. qemu-aarch64-static) added in conda-forge/conda-forge-ci-setup-feedstock#170, I think we can simple disable the UNIT_ign_TEST tests.

@Tobias-Fischer Tobias-Fischer added the automerge Merge the PR when CI passes label Dec 12, 2021
@Tobias-Fischer
Copy link
Contributor

Thanks @traversaro - LGTM (although the logic is a bit convoluted, but if it works, it works), added automerge.

@traversaro
Copy link
Contributor

Thanks @traversaro - LGTM (although the logic is a bit convoluted, but if it works, it works), added automerge.

Yes, unfortunatly that's the only way I found to cross-compile correctly packages that build and run code-generators. Fortunatly, few packages do build and run code-generators.

@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Dec 12, 2021
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@Tobias-Fischer Tobias-Fischer added the automerge Merge the PR when CI passes label Dec 12, 2021
@github-actions github-actions bot merged commit 882a9f1 into conda-forge:master Dec 12, 2021
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-libprotobuf319-0-1_hc07094 branch December 12, 2021 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants