Merge pull request #7 from adibbley/fix-rpaths

Fix RPATH for libraries.
conda-forge · Dec 6, 2023 · 168fbf5 · 168fbf5
2 parents 5a47af8 + b2afe96
commit 168fbf5
Show file tree

Hide file tree

Showing 10 changed files with 64 additions and 20 deletions.
diff --git a/.azure-pipelines/azure-pipelines-linux.yml b/.azure-pipelines/azure-pipelines-linux.yml
diff --git a/.ci_support/linux_64_.yaml b/.ci_support/linux_64_.yaml
@@ -1,7 +1,7 @@
 c_compiler:
 - gcc
 c_compiler_version:
-- '11'
+- '12'
 cdt_name:
 - cos7
 channel_sources:
@@ -11,7 +11,7 @@ channel_targets:
 cxx_compiler:
 - gxx
 cxx_compiler_version:
-- '11'
+- '12'
 docker_image:
 - quay.io/condaforge/linux-anvil-cos7-x86_64
 target_platform:

diff --git a/.scripts/build_steps.sh b/.scripts/build_steps.sh
diff --git a/.scripts/logging_utils.sh b/.scripts/logging_utils.sh
diff --git a/.scripts/run_docker_build.sh b/.scripts/run_docker_build.sh
diff --git a/README.md b/README.md
diff --git a/conda-forge.yml b/conda-forge.yml
@@ -2,7 +2,7 @@ github:
   branch_name: main
   tooling_branch_name: main
 conda_build:
-  error_overlinking: true
+  error_overlinking: false
 conda_forge_output_validation: true
 os_version:
   linux_64: cos7
diff --git a/recipe/build.sh b/recipe/build.sh
@@ -26,6 +26,10 @@ for i in `ls`; do
             for j in "$i"/*.so*; do
                 # Shared libraries are symlinked in $PREFIX/lib
                 ln -s ${PREFIX}/${targetsDir}/$j ${PREFIX}/$j
+
+                if [[ $j =~ \.so\. ]]; then
+                    patchelf --set-rpath '$ORIGIN' ${PREFIX}/${targetsDir}/$j
+                fi
             done
         fi
     else

diff --git a/recipe/meta.yaml b/recipe/meta.yaml
@@ -19,10 +19,15 @@ source:
     - Makefile.patch
 
 build:
-  number: 0
+  number: 1
+  binary_relocation: false
   skip: true  # [not (linux64 or aarch64)]
 
 test:
+  requires:
+    - patchelf  # [linux]
+  files:
+    - test-rpath.sh
   commands:
     # Note that the version of libcufile does not match
     # {{ version.split(".")[0] }} but the major version of libcufile_rdma does
@@ -37,6 +42,7 @@ test:
     - test -L $PREFIX/targets/{{ target_name }}/lib/libcufile_rdma.so.{{ version.split(".")[0] }}  # [linux64]
     - test -f $PREFIX/targets/{{ target_name }}/lib/libcufile.so.{{ full_version }}
     - test -f $PREFIX/targets/{{ target_name }}/lib/libcufile_rdma.so.{{ full_version }}  # [linux64]
+    - bash test-rpath.sh                                                                      # [linux]
 
 outputs:
   - name: libcufile
@@ -51,8 +57,9 @@ outputs:
         - {{ compiler("c") }}
         - {{ compiler("cxx") }}
         - arm-variant * {{ arm_variant_type }}  # [aarch64]
-        - sysroot_{{ target_platform }} 2.17   # [linux]
-        - {{ cdt("rdma-core-devel") }}  # [linux64]
+        - sysroot_{{ target_platform }} 2.17    # [linux]
+        - {{ cdt("rdma-core-devel") }}          # [linux64]
+        - patchelf <0.18.0                      # [linux]
       host:
         - cuda-version {{ cuda_version }}
       run:

diff --git a/recipe/test-rpath.sh b/recipe/test-rpath.sh
@@ -0,0 +1,24 @@
+#!/bin/bash
+
+[[ ${target_platform} == "linux-64" ]] && targetsDir="targets/x86_64-linux"
+[[ ${target_platform} == "linux-ppc64le" ]] && targetsDir="targets/ppc64le-linux"
+[[ ${target_platform} == "linux-aarch64" ]] && targetsDir="targets/sbsa-linux"
+
+errors=""
+
+for lib in `find ${PREFIX}/${targetsDir}/lib -type f`; do
+    [[ $lib =~ \.so ]] || continue
+
+    rpath=$(patchelf --print-rpath $lib)
+    echo "$lib rpath: $rpath"
+    [[ $rpath == "\$ORIGIN" ]] || errors+="$lib\n"
+done
+
+if [[ $errors ]]; then
+    echo "The following libraries were found with an unexpected RPATH:"
+    echo -e "$errors"
+
+    exit 1
+else
+    exit 0
+fi