Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.10.1 #57

Closed
wants to merge 1 commit into from
Closed

Version 1.10.1 #57

wants to merge 1 commit into from

Conversation

mwouts
Copy link
Contributor

@mwouts mwouts commented Feb 10, 2021

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@mwouts mwouts requested a review from grst as a code owner February 10, 2021 23:26
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@mwouts
Copy link
Contributor Author

mwouts commented Feb 10, 2021

@conda-forge-admin, please rerender

@github-actions
Copy link

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

@mwouts
Copy link
Contributor Author

mwouts commented Feb 10, 2021

I am not sure what has gone wrong here... In the .tar.gz file on pypi I see the notebook extension, but according to the tests it is missing in the (candidate) conda package.

Maybe this is caused by the removal of graft packages at mwouts/jupytext@6abaea0 ? I'll try to add it back.

@mwouts
Copy link
Contributor Author

mwouts commented Feb 11, 2021

Oh no, if I add graft packages back to the MANIFEST.in file then the .tar.gz package becomes huge again (45MB) when built locally with

BUILD_JUPYTERLAB_EXTENSION=1 python setup.py sdist bdist_wheel

@martinRenou I am afraid I'm going to need your help here once more if you don't mind 🙇

@martinRenou
Copy link
Member

I suppose you need to include everything that is in packages except node_modules

@mwouts
Copy link
Contributor Author

mwouts commented Feb 16, 2021

As appeared on the tests above, the .tar.gz package for Jupytext v1.10.1 was missing the notebook and lab extensions. This should be OK in v1.10.2 thanks to mwouts/jupytext#741 (so there won't be a v1.10.1 on conda-forge).

@mwouts mwouts closed this Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants