Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup v1.6 LTS #159

Merged
merged 37 commits into from
Jan 6, 2022
Merged

cleanup v1.6 LTS #159

merged 37 commits into from
Jan 6, 2022

Conversation

ngam
Copy link
Contributor

@ngam ngam commented Dec 26, 2021

Fixes #171
Fixes #166
Fixes #167

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

mjohnson541 and others added 8 commits August 10, 2021 08:29
* This uses the activate.sh and deactivate.sh scripts that backup the environment variable.
* Create a new shared environment located in the site depot for the environment rather than continuing to use the default one in ~/.julia/environments/v#.#.
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ngam ngam closed this Dec 26, 2021
@ngam ngam reopened this Dec 26, 2021
@ngam
Copy link
Contributor Author

ngam commented Dec 26, 2021

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/julia-feedstock/actions/runs/1624803404.

@ngam ngam mentioned this pull request Dec 27, 2021
8 tasks
@ngam ngam mentioned this pull request Jan 5, 2022
5 tasks
Copy link
Contributor

@mkitti mkitti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this fixes the 1.6 branch. I have not checked what openlibm version Julia 1.6.5 uses.

recipe/build.sh Outdated Show resolved Hide resolved
recipe/build.sh Outdated Show resolved Hide resolved
@ngam
Copy link
Contributor Author

ngam commented Jan 5, 2022

Also this fixes the 1.6 branch. I have not checked what openlibm version Julia 1.6.5 uses.

https://github.com/JuliaLang/julia/blob/96a99c268a96ee61f6ff8fe4c2d53208f0cb042a/deps/Versions.make#L86-L89

V0.7.3 --- submitting a build for that. But generally, the differences between the 0.7.x builds are very minor. That's partly why hard pinning is discouraged --- why pin so hard if you can be relax stuff? Upstream should relax their pinnings and give ranges, rather than exact pinning. Oh I forgot ... they vendor it all... 🤣

@ngam
Copy link
Contributor Author

ngam commented Jan 5, 2022

Also this fixes the 1.6 branch. I have not checked what openlibm version Julia 1.6.5 uses.

https://github.com/JuliaLang/julia/blob/96a99c268a96ee61f6ff8fe4c2d53208f0cb042a/deps/Versions.make#L86-L89

V0.7.3 --- submitting a build for that. But generally, the differences between the 0.7.x builds are very minor. That's partly why hard pinning is discouraged --- why pin so hard if you can be relax stuff? Upstream should relax their pinnings and give ranges, rather than exact pinning. Oh I forgot ... they vendor it all... 🤣

update: not going to build v0.7.3 --- will require a significant patch to work that will only basically make it v0.7.4. So we can safely use v0.7.4 or v0.7.5 here.

JuliaMath/openlibm@v0.7.3...v0.7.4

@mkitti mkitti added the automerge Merge the PR when CI passes label Jan 6, 2022
@github-actions github-actions bot merged commit e07c7bd into conda-forge:v1.6 Jan 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2022

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@SylvainCorlay
Copy link
Member

This appears to cause some breakage downstream.

Julia is looking for PREFIX/lib/julia/libopenlibm.so (or dylib) at runtime and not finding it.

@SylvainCorlay
Copy link
Member

@mkitti
Copy link
Contributor

mkitti commented Jan 7, 2022

@SylvainCorlay the logs show you are using 1.6.5-h132cb31_0 and not the builds produced about 29 hours ago ( osx-64/julia-1.6.5-h132cb31_1.tar.bz2 )

@SylvainCorlay
Copy link
Member

Thanks, it seems to be fixed with the newest build indeed.

@SylvainCorlay
Copy link
Member

SylvainCorlay commented Jan 7, 2022

@mkitti I am seeing the latest build of Julia segfault when doing Pkg.install.

https://github.com/xtensor-stack/xtensor-julia/runs/4738787473?check_suite_focus=true

@mkitti
Copy link
Contributor

mkitti commented Jan 7, 2022

The segfaults are occurring in libcurl ... and 7.81 was just released on conda-forge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants