-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mbedtls #126
Merged
Merged
Mbedtls #126
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,118 @@ | ||
From 620661455ec175ecd50c49f08e1ac4f6fdb84a78 Mon Sep 17 00:00:00 2001 | ||
From: Ista Zahn <[email protected]> | ||
Date: Mon, 20 Sep 2021 10:56:40 -0400 | ||
Subject: [PATCH] remove more hard coded libraries | ||
|
||
--- | ||
stdlib/LibGit2_jll/src/LibGit2_jll.jl | 4 ++-- | ||
stdlib/LibSSH2_jll/src/LibSSH2_jll.jl | 4 ++-- | ||
stdlib/MbedTLS_jll/src/MbedTLS_jll.jl | 12 ++++++------ | ||
stdlib/OpenLibm_jll/src/OpenLibm_jll.jl | 4 ++-- | ||
stdlib/libLLVM_jll/src/libLLVM_jll.jl | 2 +- | ||
stdlib/nghttp2_jll/src/nghttp2_jll.jl | 4 ++-- | ||
6 files changed, 15 insertions(+), 15 deletions(-) | ||
|
||
diff --git a/stdlib/LibGit2_jll/src/LibGit2_jll.jl b/stdlib/LibGit2_jll/src/LibGit2_jll.jl | ||
index 8d1629e..b5a3b60 100644 | ||
--- a/stdlib/LibGit2_jll/src/LibGit2_jll.jl | ||
+++ b/stdlib/LibGit2_jll/src/LibGit2_jll.jl | ||
@@ -21,9 +21,9 @@ libgit2_path = "" | ||
if Sys.iswindows() | ||
const libgit2 = "libgit2.dll" | ||
elseif Sys.isapple() | ||
- const libgit2 = "@rpath/libgit2.1.1.dylib" | ||
+ const libgit2 = "@rpath/libgit2.dylib" | ||
else | ||
- const libgit2 = "libgit2.so.1.1" | ||
+ const libgit2 = "libgit2.so" | ||
end | ||
|
||
function __init__() | ||
diff --git a/stdlib/LibSSH2_jll/src/LibSSH2_jll.jl b/stdlib/LibSSH2_jll/src/LibSSH2_jll.jl | ||
index 69a2fe6..6bd21b3 100644 | ||
--- a/stdlib/LibSSH2_jll/src/LibSSH2_jll.jl | ||
+++ b/stdlib/LibSSH2_jll/src/LibSSH2_jll.jl | ||
@@ -21,9 +21,9 @@ libssh2_path = "" | ||
if Sys.iswindows() | ||
const libssh2 = "libssh2.dll" | ||
elseif Sys.isapple() | ||
- const libssh2 = "@rpath/libssh2.1.dylib" | ||
+ const libssh2 = "@rpath/libssh2.dylib" | ||
else | ||
- const libssh2 = "libssh2.so.1" | ||
+ const libssh2 = "libssh2.so" | ||
end | ||
|
||
function __init__() | ||
diff --git a/stdlib/MbedTLS_jll/src/MbedTLS_jll.jl b/stdlib/MbedTLS_jll/src/MbedTLS_jll.jl | ||
index a7ca666..62774b9 100644 | ||
--- a/stdlib/MbedTLS_jll/src/MbedTLS_jll.jl | ||
+++ b/stdlib/MbedTLS_jll/src/MbedTLS_jll.jl | ||
@@ -27,13 +27,13 @@ if Sys.iswindows() | ||
const libmbedtls = "libmbedtls.dll" | ||
const libmbedx509 = "libmbedx509.dll" | ||
elseif Sys.isapple() | ||
- const libmbedcrypto = "@rpath/libmbedcrypto.5.dylib" | ||
- const libmbedtls = "@rpath/libmbedtls.13.dylib" | ||
- const libmbedx509 = "@rpath/libmbedx509.1.dylib" | ||
+ const libmbedcrypto = "@rpath/libmbedcrypto.dylib" | ||
+ const libmbedtls = "@rpath/libmbedtls.dylib" | ||
+ const libmbedx509 = "@rpath/libmbedx509.dylib" | ||
else | ||
- const libmbedcrypto = "libmbedcrypto.so.5" | ||
- const libmbedtls = "libmbedtls.so.13" | ||
- const libmbedx509 = "libmbedx509.so.1" | ||
+ const libmbedcrypto = "libmbedcrypto.so" | ||
+ const libmbedtls = "libmbedtls.so" | ||
+ const libmbedx509 = "libmbedx509.so" | ||
end | ||
|
||
function __init__() | ||
diff --git a/stdlib/OpenLibm_jll/src/OpenLibm_jll.jl b/stdlib/OpenLibm_jll/src/OpenLibm_jll.jl | ||
index e0ac190..1f64e24 100644 | ||
--- a/stdlib/OpenLibm_jll/src/OpenLibm_jll.jl | ||
+++ b/stdlib/OpenLibm_jll/src/OpenLibm_jll.jl | ||
@@ -20,9 +20,9 @@ libopenlibm_path = "" | ||
if Sys.iswindows() | ||
const libopenlibm = "libopenlibm.dll" | ||
elseif Sys.isapple() | ||
- const libopenlibm = "@rpath/libopenlibm.3.dylib" | ||
+ const libopenlibm = "@rpath/libopenlibm.dylib" | ||
else | ||
- const libopenlibm = "libopenlibm.so.3" | ||
+ const libopenlibm = "libopenlibm.so" | ||
end | ||
|
||
function __init__() | ||
diff --git a/stdlib/libLLVM_jll/src/libLLVM_jll.jl b/stdlib/libLLVM_jll/src/libLLVM_jll.jl | ||
index fa45e75..b51812e 100644 | ||
--- a/stdlib/libLLVM_jll/src/libLLVM_jll.jl | ||
+++ b/stdlib/libLLVM_jll/src/libLLVM_jll.jl | ||
@@ -23,7 +23,7 @@ if Sys.iswindows() | ||
elseif Sys.isapple() | ||
const libLLVM = "@rpath/libLLVM.dylib" | ||
else | ||
- const libLLVM = "libLLVM-11jl.so" | ||
+ const libLLVM = "libLLVM.so" | ||
end | ||
|
||
function __init__() | ||
diff --git a/stdlib/nghttp2_jll/src/nghttp2_jll.jl b/stdlib/nghttp2_jll/src/nghttp2_jll.jl | ||
index 8b98c76..d926449 100644 | ||
--- a/stdlib/nghttp2_jll/src/nghttp2_jll.jl | ||
+++ b/stdlib/nghttp2_jll/src/nghttp2_jll.jl | ||
@@ -20,9 +20,9 @@ libnghttp2_path = "" | ||
if Sys.iswindows() | ||
const libnghttp2 = "libnghttp2-14.dll" | ||
elseif Sys.isapple() | ||
- const libnghttp2 = "@rpath/libnghttp2.14.dylib" | ||
+ const libnghttp2 = "@rpath/libnghttp2.dylib" | ||
else | ||
- const libnghttp2 = "libnghttp2.so.14" | ||
+ const libnghttp2 = "libnghttp2.so" | ||
end | ||
|
||
function __init__() | ||
-- | ||
2.33.0 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you remove the pin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used https://github.com/archlinux/svntogit-community/blob/packages/julia/trunk/julia-hardcoded-libs.patch to patch out the hard-coded
mbedtls
version. Since that patch also removessuitesparse
version hard-coding we don't need to pin anymore.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be interested to see how this interacts with the issue in #118, which is why the pin was added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we should test to make sure that issue is fixed by this PR before merging.