Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
another go at fixing 1.6 builds #115
another go at fixing 1.6 builds #115
Changes from all commits
f9fb9a8
e59adf1
c11c2f2
ffeb708
a67508e
72c7c39
73fcdd8
ac7a039
0c3be4f
0a690da
d539a9f
2b2f7b6
93cdbc5
bdddcc3
880984f
6cac917
70be393
26d001c
c28b47f
3af4f7b
3f7a7f2
d7a5ff7
cfc570f
41053fa
5b4e05e
495c106
0aa0bae
38e9576
1aca9e2
5273977
620aa6a
89bb2fb
a24b788
a296475
6734950
3c98953
0dfa35b
c9bdf28
2da0e10
04d3113
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does fftw need to be added to the dependencies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, FFTW isn't a dependency of Julia itself since JuliaLang/julia#21956
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the previous tests part of the new tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No,
LibGit2/online Pkg/pkg
are not part of the new tests.The old tests focus only on subsets of the
LibGit2
andPkg
stdlib packages. They are actually not included in the default tests except when explicit requested. They were a weird choice for the only tests to run.https://github.com/JuliaLang/julia/blob/68c458519d369d922e1bfc2c8f9bb240c8718eaa/test/choosetests.jl#L153-L154
Above in a previous comment I ran the standard test suite. It takes some time to run, which has been the subject of complaints in the git history.
The available tests to run are below:
$ make print-TESTS
TESTS=all stdlib unicode strings compiler NetworkOptions Artifacts CompilerSupportLibraries_jll SHA Zlib_jll Statistics Random LibGit2_jll DelimitedFiles Pkg CRC32c Profile OpenBLAS_jll nghttp2_jll OpenLibm_jll SparseArrays LibSSH2_jll p7zip_jll LibCURL_jll InteractiveUtils MPFR_jll MbedTLS_jll LinearAlgebra Distributed Test TOML ArgTools Logging FileWatching UUIDs Libdl Base64 Tar Markdown Sockets GMP_jll Serialization LibGit2 LibCURL Dates LibUnwind_jll Mmap SuiteSparse REPL PCRE2_jll Unicode SuiteSparse_jll libblastrampoline_jll SharedArrays LibUV_jll LLVMLibUnwind_jll libLLVM_jll MozillaCACerts_jll Future Printf LazyArtifacts Downloads dSFMT_jll subarray ambiguous filesystem arrayops read path error float16 precompile stacktraces triplequote iobuffer bitarray client stress corelogging sysinfo exceptions ordering checked loading complex ranges deprecation_exec math binaryplatforms cartesian threads_exec misc ccall sorting syntax goto hashing channels numbers spawn simdloop rational intrinsics subtype reinterpretarray interpreter test_sourcepath secretbuffer int rounding combinatorics opaque_closure euler asyncmap mod2pi parse specificity test_exec boundscheck_exec some choosetests smallarrayshrink worlds backtrace fastmath broadcast meta docs reduce env staged osutils iostream namedtuple show boundscheck core dict download_exec tuple atomics copy download gmp cmdlineargs reducedim floatapprox file atexit reflection abstractarray intfuncs char threads llvmcall2 sets mpfr iterators stress_fd_exec bitset vecelement errorshow generic_map_tests missing operators enums keywordargs functional offsetarray floatfuncs testenv stack_overflow version regex llvmcall ryu unicode/utf8 strings/io strings/util strings/search strings/types strings/basic compiler/inference compiler/validation compiler/interpreter_exec compiler/codegen compiler/contextual compiler/inline compiler/ssair compiler/irpasses