ARM OSX Migrator #60
ARM OSX Migrator #60
Conversation
…nda-forge-pinning 2021.07.15.07.57.26
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Ping @conda-forge/help-osx-arm64! I believe this PR should be closed because the JAX team is in the process of building m1 wheels. (Referencing jax-ml/jax#5501 for clarity.) What is your opinion here? |
|
Please keep this open as merging or closing this PR indicates that we have released M1 support for this on conda-forge. Also I would really like to get this building |
|
Understood, thank you @xhochy! Okie dokes, I won't close the PR. By the way, please do let me know how I can help. If we can find the time together, I would love to observe how you debug the builds (especially with bazel involved); my lack of knowledge on bazel (and perhaps lack of patience too) means I've never managed to get a build-from-source of JAX working 😹 Being able to observe might help me better understand the internals of conda-forge, as at the moment, I also only know how to do vanilla Python packages but nothing more. |
xhochy
force-pushed
the
bot-pr_arm_osx_hc05aaa
branch
from
abb52b0
to
8795bb3
Compare
I'd love to do this but my time (at least this week) is so fuzzy that I cannot commit to anything. I'll keep working here a bit. Bazel is a quite complicated affair (you see this as I changed nearly 1k lines here), other build systems are much simpler. Thus getting to understand things is much much simpler. Still, let's do this some time! |
xhochy
force-pushed
the
bot-pr_arm_osx_hc05aaa
branch
from
d172033
to
9b49dd2
Compare
|
CI is green 🎇 |
|
OMG, @xhochy!!!!!! HOW DID YOU DO IT?!?!?! I kinda wanna now give you a call and do an interview, podcast-style. |
|
@xhochy This is a real tour de force. Congratulations! |
|
@xhochy wow, I looked through the changes and dang that's a really, really big effort here. Before we hit the big green button, I really want to record a call with you where we go through what you did and put it up on youtube. Do you think you'd be game for this? |
Most of this builds upon the work in conda-forge/tensorflow-feedstock#110 Before we merged, I'll move this into a separate package before it gets copy-pasted to even more packages.
Happy to do this but finding a time slot won't be that easy currently. I have sent you a mail about this. Otherwise, I hope that the commits here are split up enough to show my approach. I did force-push a few times where I struggled to commit the right code instead of adding a new commit but that just shows that it isn't easy to get right on the first try. |
|
@ericmjl are you OK merging this now to unlock conda-forge/jax-feedstock#63 ? |
|
@beckermr FYI |
|
@ericmjl I would merge this today, OK? |
|
Yes, thank you, @xhochy! |
This feedstock is being rebuilt as part of the ARM OSX migration.
Feel free to merge the PR if CI is all green, but please don't close it
without reaching out the the ARM OSX team first at @conda-forge/help-osx-arm64.
If this PR was opened in error or needs to be updated please add the
bot-rerunlabel to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun botin a PR comment to have theconda-forge-adminadd it for you.This PR was created by the regro-cf-autotick-bot.
The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (
conda install -c conda-forge rever) and pip (pip install re-ver) installable.Finally, feel free to drop us a line if there are any issues!
This PR was generated by https://github.com/regro/autotick-bot/actions/runs/1035160982, please use this URL for debugging