Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implicit v0.7.0 #56

Merged
merged 10 commits into from
Jun 21, 2023
Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.

Packages found by source code inspection but not in the meta.yaml:

  • h5py
  • scikit-build
  • python-annoy
  • faiss
  • packaging
  • nmslib

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/5252028130, please use this URL for debugging.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • Old-style Python selectors (py27, py34, py35, py36) are deprecated. Instead, consider using the int py. For example: # [py>=36]. See lines [19]

@benfred benfred mentioned this pull request Jun 13, 2023
5 tasks
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@benfred
Copy link
Contributor

benfred commented Jun 13, 2023

The build error for the cuda builds seems similar to NVIDIA/spark-rapids-jni#479 - with the relevant bits being

  -- CPM: rmm: adding package [email protected] (1.17.2)
  CMake Deprecation Warning at _skbuild/linux-x86_64-3.10/cmake-build/_deps/thrust-src/CMakeLists.txt:9 (cmake_policy):
    The OLD behavior for policy CMP0104 will be removed from a future version
    of CMake.

    The cmake-policies(7) manual explains that the OLD behaviors of all
    policies are deprecated and that a policy should be set to OLD only under
    specific short-term circumstances.  Projects should be ported to the NEW
    behavior and not rely on setting a policy to OLD.


  CMake Error at _skbuild/linux-x86_64-3.10/cmake-build/_deps/thrust-src/thrust/cmake/thrust-config-version.cmake:4 (file):
    file failed to open for reading (No such file or directory):

      /home/conda/feedstock_root/build_artifacts/implicit_1686677296183/work/_skbuild/linux-x86_64-3.10/cmake-build/_deps/thrust-src/_THRUST_VERSION_INCLUDE_DIR-NOTFOUND/thrust/version.h
  Call Stack (most recent call first):
    _skbuild/linux-x86_64-3.10/cmake-build/_deps/thrust-src/cmake/ThrustAddSubdir.cmake:1 (find_package)
    _skbuild/linux-x86_64-3.10/cmake-build/_deps/thrust-src/CMakeLists.txt:42 (include)


  CMake Error at _skbuild/linux-x86_64-3.10/cmake-build/_deps/thrust-src/thrust/cmake/thrust-config-version.cmake:11 (math):
    math cannot parse the expression: " / 100000": syntax error, unexpected
    exp_DIVIDE (2).
  Call Stack (most recent call first):
    _skbuild/linux-x86_64-3.10/cmake-build/_deps/thrust-src/cmake/ThrustAddSubdir.cmake:1 (find_package)
    _skbuild/linux-x86_64-3.10/cmake-build/_deps/thrust-src/CMakeLists.txt:42 (include)

@benfred
Copy link
Contributor

benfred commented Jun 13, 2023

also similar rapidsai/raft#678 (comment)

@benfred
Copy link
Contributor

benfred commented Jun 20, 2023

@conda-forge-admin please rerender

@benfred benfred merged commit b3273c5 into conda-forge:main Jun 21, 2023
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 0.7.0_h13b28e branch June 21, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants