Run tests on Windows #81
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
All the Windows builds pass except for the VS2008 32-bit build, which fails on both Don't know who to ask about this. @jreadey, do you know who I should ask about these Windows test failures? |
jakirkham
force-pushed
the
windows_tests
branch
from
eab4686 to
d519641
Compare
|
Friendly bump 😊 |
|
@conda-forge-admin, please restart ci |
conda-forge-webservices
bot
requested review from
SylvainCorlay,
astrofrog-conda-forge,
davidbrochart,
gillins,
groutr,
hmaarrfk,
marcelotrevisani,
ocefpaf,
scopatz and
varlackc
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
um, you might want to remake the PR cherry-picking the commit. not sure if this is out of sync. |
|
Historically, only "light tests" have been done on conda-forge packages. is there somehting of concern with the HDF5 libraries on windows? |
|
Nothin major. In netcdf-fortran there is a test for libsz which fails on Windows. Working my way up through netcdf-c, I found the comment here that sz never worked on Windows anyway, so I was curious to see this PR, but happy to close or leave a comment that there are no plans to tackle this. |
|
Well, I'll soften @hmaarrfk 's statement. Different packages do different things. Fundamentally, the tests are there to ensure that the built packages aren't broken. For simpler packages (pure Python, straightforward operation), it can be enough to do an import or some other manual test (e.g. a CLI app) to ensure things are installed right and linked properly. Other packages are significantly more complicated due to numerics, build options, etc. NumPy and SciPy run their full test suites, as does libnetcdf. In fact, it's only because of running the full test suite that we're aware of issues compiling with -O3 on netcdf on ppc64le and (now) mac x86. I wouldn't say it's bad to run the full test suite here, but somebody has to do the work to get it working. |
|
Ok debugging failures in other packages is valid. The other concern i often have is build time. |
|
but build time (and test time) seems to be ok |
|
@conda-forge-admin, please restart ci |
|
@conda-forge-admin, please rerender |
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like I wasn't able to push to the windows_tests branch of jakirkham-feedstocks/hdf5-feedstock. Did you check the "Allow edits from maintainers" box? NOTE: PRs from organization accounts or PRs from forks made from organization forks cannot be rerendered because of GitHub permissions. Please fork the feedstock directly from conda-forge into your personal GitHub account. This message was generated by GitHub actions workflow run https://github.com/conda-forge/hdf5-feedstock/actions/runs/5109065708. |
Supersedes PR ( #44 ).
Starts running HDF5's tests on Windows.