Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build for both protobuf 4.25.3 and 5.27.3 #44

Merged
merged 5 commits into from
Sep 30, 2024

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Sep 29, 2024

Hardcode double protobuf pinning as a workaround for https://github.com/conda-forge/gz-common-feedstock/issues/48k, revert once conda-forge/openvino-feedstock#106 is merged.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

@conda-forge-admin please rerender

@traversaro
Copy link
Contributor Author

Requires conda-forge/gz-msgs-feedstock#42 .

@traversaro
Copy link
Contributor Author

Error:

____________________ ERROR collecting test/options_TEST.py _____________________
ImportError while importing test module '/home/conda/feedstock_root/build_artifacts/gz-transport14_1727676423780/work/python/test/options_TEST.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
../../../_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
../test/options_TEST.py:1: in <module>
    from gz.msgs11.stringmsg_pb2 import StringMsg
../../../_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.10/site-packages/gz/msgs11/stringmsg_pb2.py:9: in <module>
    from google.protobuf import runtime_version as _runtime_version
E   ImportError: cannot import name 'runtime_version' from 'google.protobuf' (/home/conda/feedstock_root/build_artifacts/gz-transport14_1727676423780/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.10/site-packages/google/protobuf/__init__.py)
- generated xml file: /home/conda/feedstock_root/build_artifacts/gz-transport14_1727676423780/work/python/build/test_results/options_TEST.xml -
=========================== short test summary info ============================
ERROR ../test/options_TEST.py
!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
=============================== 1 error in 0.17s ===============================

My guess is that the gz-msgs python msgs have a runtime requirement on the given protobuf version with which they have been generated, but we are not doing that.

@traversaro
Copy link
Contributor Author

My guess is that the gz-msgs python msgs have a runtime requirement on the given protobuf version with which they have been generated, but we are not doing that.

Fixed by conda-forge/gz-msgs-feedstock#43 .

@traversaro traversaro merged commit e762870 into conda-forge:main Sep 30, 2024
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant