Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for libabseil20230125 #126

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update libabseil20230125.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/4186133814, please use this URL for debugging.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari h-vetinari added the automerge Merge the PR when CI passes label Feb 16, 2023
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: failed

Thus the PR was not passing and not merged.

@h-vetinari
Copy link
Member

@coryan, we have two ways to fix this here on OSX:

  • [simple, less usable] add the same kind of if-condition as in 2653885 also to run_test_google_cloud_cpp.sh; this papers over the problem, and every consumer of google-cloud-cpp in conda-forge would have to set _LIBCPP_DISABLE_AVAILABILITY on osx.
  • [more involved, more user-friendly]: add _LIBCPP_DISABLE_AVAILABILITY to the compilation interface as here; if we want to do the latter, I'll probably need your help where to add this. I've just looked at the CMake files and couldn't find a simple spot where I'd need to add something like this.

Thoughts?

@coryan
Copy link
Contributor

coryan commented Feb 16, 2023

@coryan, we have two ways to fix this here on OSX:

  • [simple, less usable] add the same kind of if-condition as in 2653885 also to run_test_google_cloud_cpp.sh; this papers over the problem, and every consumer of google-cloud-cpp in conda-forge would have to set _LIBCPP_DISABLE_AVAILABILITY on osx.

If I am reading https://conda-forge.org/docs/maintainer/knowledge_base.html#newer-c-features-with-old-sdk correctly, it seems that _LIBCPP_DISABLE_AVAILABILITY should be defined by Conda's libcxx package. I assume there are good reasons why it does not do so.

  • [more involved, more user-friendly]: add _LIBCPP_DISABLE_AVAILABILITY to the compilation interface as here; if we want to do the latter, I'll probably need your help where to add this. I've just looked at the CMake files and couldn't find a simple spot where I'd need to add something like this.

With the proviso that these CMake files are mostly unfamiliar to me too. One approach would be to add target_compile_definitions(... PUBLIC _LIBCPP_DISABLE_AVAILABILITY) in every function that defines libraries. That means these three locations:

https://github.com/abseil/abseil-cpp/blob/b54044578175b6949fb151b4d8be9153d7093c31/CMake/AbseilHelpers.cmake#L279
https://github.com/abseil/abseil-cpp/blob/b54044578175b6949fb151b4d8be9153d7093c31/CMake/AbseilHelpers.cmake#L336
https://github.com/abseil/abseil-cpp/blob/b54044578175b6949fb151b4d8be9153d7093c31/CMake/AbseilDll.cmake#L776-L786

There is one more use of target_compile_definitions() in the project (here but it is in one of the functions already covered. You can also search for all the uses of add_library() (results). I think they are all covered by the previous sugestion

@h-vetinari
Copy link
Member

If I am reading https://conda-forge.org/docs/maintainer/knowledge_base.html#newer-c-features-with-old-sdk correctly, it seems that _LIBCPP_DISABLE_AVAILABILITY should be defined by Conda's libcxx package. I assume there are good reasons why it does not do so.

That's a very good question I don't know the answer to. @isuruf, any reason why we haven't added _LIBCPP_DISABLE_AVAILABILITY to the interface of libcxx (on osx) by default?

@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Feb 19, 2023
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@h-vetinari
Copy link
Member

OK, taking the easy way out here for now (not many consumers anyway). We can reconsider to do this more comprehensively (either here or in libcxx) in the future.

@h-vetinari h-vetinari added the automerge Merge the PR when CI passes label Feb 19, 2023
@h-vetinari h-vetinari merged commit 8fdc16b into conda-forge:main Feb 20, 2023
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-libabseil20230125-0-1_habff64 branch February 20, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants