Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gds-base 3.0.1 #20

Merged
merged 16 commits into from
Sep 3, 2024
Merged

gds-base 3.0.1 #20

merged 16 commits into from
Sep 3, 2024

Conversation

duncanmmacleod
Copy link
Contributor

Checklist

source package was renamed
remove run requirements for packages that use run_exports
this package is no longer provided
mainly to provide zlibcflags to stop the build looking in /usr/
@duncanmmacleod duncanmmacleod requested a review from emaros as a code owner March 10, 2024 12:16
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@duncanmmacleod duncanmmacleod added the automerge Merge the PR when CI passes label Mar 10, 2024
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: failed

Thus the PR was not passing and not merged.

@duncanmmacleod
Copy link
Contributor Author

This is blocked by https://git.ligo.org/gds/gds/-/issues/181.

@h-vetinari
Copy link
Member

This is blocked by https://git.ligo.org/gds/gds/-/issues/181.

This is not publicly visible - any updates?

@duncanmmacleod
Copy link
Contributor Author

This is blocked by https://git.ligo.org/gds/gds/-/issues/181.

This is not publicly visible - any updates?

No, unfortunately not. I have pinged the package libraries on that ticket and am waiting for a reply.

@h-vetinari
Copy link
Member

OK, thanks for checking. While we're waiting for that, would you mind if I make a small commit (or you do!) as follows?

  - name: gds-base-monitors
    script: install-base-monitors.sh
    build:
-      ignore_run_exports:
+      ignore_run_exports_from:
        # the build needs the c++ compiler, but doesn't
        # link against it
-       - libcxx  # [osx]
-       - libstdcxx-ng  # [linux]
+       - {{ compiler('cxx') }}
      run_exports:
        - {{ pin_subpackage("gds-base-monitors", max_pin="x") }}
    requirements:

@duncanmmacleod
Copy link
Contributor Author

OK, thanks for checking. While we're waiting for that, would you mind if I make a small commit (or you do!) as follows?

  - name: gds-base-monitors
    script: install-base-monitors.sh
    build:
-      ignore_run_exports:
+      ignore_run_exports_from:
        # the build needs the c++ compiler, but doesn't
        # link against it
-       - libcxx  # [osx]
-       - libstdcxx-ng  # [linux]
+       - {{ compiler('cxx') }}
      run_exports:
        - {{ pin_subpackage("gds-base-monitors", max_pin="x") }}
    requirements:

@h-vetinari, please carry on, I will review things as soon as I can get a patch from upstream.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Aug 16, 2024
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

manually specify -undefined dynamic_lookup for osx-arm64 to resolve many, many undefined symbol errors
@duncanmmacleod duncanmmacleod merged commit d7d2c98 into conda-forge:main Sep 3, 2024
7 checks passed
@duncanmmacleod duncanmmacleod deleted the 3.0.1 branch September 3, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants