Skip to content

Commit

Permalink
Merge pull request #54 from traversaro/add-smoke-tests
Browse files Browse the repository at this point in the history
Add on Linux/macOS smoke tests and fix OpenAL macOS problems
  • Loading branch information
traversaro authored Mar 3, 2021
2 parents 984e7f8 + bd7110d commit 1a8dac7
Show file tree
Hide file tree
Showing 15 changed files with 156 additions and 37 deletions.
2 changes: 2 additions & 0 deletions .ci_support/linux_64_.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ qt:
- '5.12'
target_platform:
- linux-64
tbb_devel:
- '2020'
zip_keys:
- - c_compiler_version
- cxx_compiler_version
Expand Down
7 changes: 0 additions & 7 deletions .ci_support/migrations/libprotobuf315.yaml

This file was deleted.

2 changes: 2 additions & 0 deletions .ci_support/osx_64_.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ qt:
- '5.12'
target_platform:
- osx-64
tbb_devel:
- '2020'
zip_keys:
- - c_compiler_version
- cxx_compiler_version
Expand Down
2 changes: 2 additions & 0 deletions .ci_support/win_64_.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,5 @@ qt:
- '5.12'
target_platform:
- win-64
tbb_devel:
- '2020'
2 changes: 1 addition & 1 deletion .github/CODEOWNERS

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

30 changes: 27 additions & 3 deletions .scripts/build_steps.sh

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

30 changes: 30 additions & 0 deletions .scripts/logging_utils.sh

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions .scripts/run_docker_build.sh

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

34 changes: 16 additions & 18 deletions .scripts/run_osx_build.sh

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion LICENSE.txt

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 7 additions & 6 deletions README.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 26 additions & 0 deletions recipe/disable-openal.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
diff --git a/cmake/SearchForStuff.cmake b/cmake/SearchForStuff.cmake
index 3d87f4305d..ee4978c4db 100644
--- a/cmake/SearchForStuff.cmake
+++ b/cmake/SearchForStuff.cmake
@@ -71,13 +71,14 @@ else ()
endif ()

########################################
-include (FindOpenAL)
-if (NOT OPENAL_FOUND)
- BUILD_WARNING ("OpenAL not found, audio support will be disabled.")
- set (HAVE_OPENAL OFF CACHE BOOL "HAVE OpenAL" FORCE)
-else ()
- set (HAVE_OPENAL ON CACHE BOOL "HAVE OpenAL" FORCE)
-endif ()
+# include (FindOpenAL)
+# if (NOT OPENAL_FOUND)
+# BUILD_WARNING ("OpenAL not found, audio support will be disabled.")
+# set (HAVE_OPENAL OFF CACHE BOOL "HAVE OpenAL" FORCE)
+# else ()
+# set (HAVE_OPENAL ON CACHE BOOL "HAVE OpenAL" FORCE)
+# endif ()
+set (HAVE_OPENAL OFF CACHE BOOL "HAVE OpenAL" FORCE)

########################################
find_package(HDF5 COMPONENTS C CXX)
25 changes: 25 additions & 0 deletions recipe/link_openal.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
From 075c13de5c5553f6290c1a53a39d9165fc8cfd76 Mon Sep 17 00:00:00 2001
From: Silvio Traversaro <[email protected]>
Date: Tue, 2 Mar 2021 19:13:27 +0100
Subject: [PATCH] Fix missing link to OpenAL in gazebo_util library

---
gazebo/util/CMakeLists.txt | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/gazebo/util/CMakeLists.txt b/gazebo/util/CMakeLists.txt
index 2c69f2b250..5831fc1aab 100644
--- a/gazebo/util/CMakeLists.txt
+++ b/gazebo/util/CMakeLists.txt
@@ -85,6 +85,10 @@ target_link_libraries(gazebo_util
${IGNITION-MSGS_LIBRARIES}
)

+if (HAVE_OPENAL)
+ target_link_libraries(gazebo_util ${OPENAL_LIBRARY})
+endif()
+
# define if tinxml2 major version >= 6
# https://github.com/ignitionrobotics/ign-common/issues/28
if (NOT tinyxml2_VERSION VERSION_LESS "6.0.0")

6 changes: 5 additions & 1 deletion recipe/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,10 @@ source:
- normalize-ogre-path.patch
- cmake_129_workaround.patch # [unix]
- 2906.patch
- disable-openal.patch

build:
number: 7
number: 8
skip: false
run_exports:
- {{ pin_subpackage('gazebo', max_pin='x') }}
Expand Down Expand Up @@ -125,6 +126,9 @@ test:
- test -f $PREFIX/bin/gzserver # [unix]
- test -f $PREFIX/bin/gzclient # [unix]
- test -f $PREFIX/bin/gazebo # [unix]
- gzserver --version | grep "Gazebo multi-robot simulator, version" # [unix]
- gzclient --version | grep "Gazebo multi-robot simulator, version" # [unix]
- gazebo --version | grep "Gazebo multi-robot simulator, version" # [unix]

about:
home: http://gazebosim.org/
Expand Down
6 changes: 6 additions & 0 deletions recipe/yum_requirements.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
mesa-libGL
mesa-dri-drivers
libselinux
libXdamage
libXxf86vm
libXext

0 comments on commit 1a8dac7

Please sign in to comment.