Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build for v0.20 #28

Merged
merged 9 commits into from
May 12, 2022
Merged

Build for v0.20 #28

merged 9 commits into from
May 12, 2022

Conversation

registerrier
Copy link
Contributor

@registerrier registerrier commented May 12, 2022

Checklist

  • [x ] Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • [x ] Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

@registerrier
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Old-style Python selectors (py27, py35, etc) are only available for Python 2.7, 3.4, 3.5, and 3.6. Please use explicit comparisons with the integer py, e.g. # [py==37] or # [py>=37]. See lines [16]

For recipe:

  • Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

@registerrier
Copy link
Contributor Author

@conda-forge-admin, please rerender

@registerrier
Copy link
Contributor Author

@conda-forge-admin, please rerender

@registerrier
Copy link
Contributor Author

@conda-forge-admin, please rerender

@mwcraig
Copy link
Contributor

mwcraig commented May 12, 2022

@registerrier -- I think the pip release yesterday may have broken things. Can you try restricting pip to <22.1 to see if that fixes t prob?

@registerrier
Copy link
Contributor Author

@conda-forge-admin, please rerender

@mwcraig
Copy link
Contributor

mwcraig commented May 12, 2022

That is progress -- it looks like the issue now is that the license file is not where the recipe expects it to be.

@registerrier
Copy link
Contributor Author

@conda-forge-admin, please rerender

@mwcraig
Copy link
Contributor

mwcraig commented May 12, 2022

You might want to change the pip pin to pip !=22.1 so that when a new pip is released you will pick that up. Based on the discussion in pypa/pip#11116 it sounds like this will be fixed in pip.

@adonath
Copy link
Member

adonath commented May 12, 2022

Thanks a lot @mwcraig for your help!

@adonath adonath merged commit 2cf838c into conda-forge:main May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants