-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update flang to 11.0.1 #17
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
Documentation on acceptable licenses can be found here. |
@conda-forge-admin Please rerender. |
…da-forge-pinning 2021.01.26.08.41.30
@isuruf a little help? https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=269656&view=logs&j=a70f640f-cc53-5cd3-6cdc-236a1aa90802&t=f5d15007-a01c-5ad8-c9ce-4d519d3b275f&l=107083 The current scheme creates a new environment, which seems to break the ninja paths. |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
For recipe:
Documentation on acceptable licenses can be found here. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
Documentation on acceptable licenses can be found here. |
@isuruf cmake appears to install to "build env" rather than "h env". I tried to fix it, but failed. |
Can you revert to 6c280b5 ? That run failed because llvmdev 11 is not patched to produce a |
@isuruf That's not correct. I reconfigured flang so that it doesn't require a patched clang or llvm. See https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=269696&view=logs&j=a70f640f-cc53-5cd3-6cdc-236a1aa90802&t=f5d15007-a01c-5ad8-c9ce-4d519d3b275f&l=107152, (scroll down to 107180). That build failed because it copied the files to
we see that two files are copied here:
|
Note: it shouldn't be too difficult to get linux working with this as well, but I don't have a linux box and I'm currently too lazy to install wsl. |
@isuruf before you merge this, I have some minor fixes, so I'd like to update the commit. Let me know if you're okay with this first. |
anything else? |
Wait libflang needs pgmath as well, maybe |
@isuruf This looks good. |
@isuruf I went ahead an confirmed that this works on OpenBLAS with enhanced testing (OpenMathLib/OpenBLAS#3088). |
Is |
I can say with complete certainty that the flang.dll that this produces is ABI-compatible with the DLL from the official flang project (if one were to be generated). The official flang project extracted some of the math functionality into a new "pgmath.dll" library. This is not a change that I made; I simply have as few changes as possible with the official flang project, while fixing any major bugs. |
I think it would be nice to have a new flang though, because right now the clang version is stuck at 5, and flang is the only fortran compiler in conda-forge for windows. |
@isuruf Is there anything else? |
Thanks |
Also, use stock clangdev, llvmdev, and remove flang-meta package.