Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update flang to 11.0.1 #17

Merged
merged 30 commits into from
Jan 31, 2021
Merged

update flang to 11.0.1 #17

merged 30 commits into from
Jan 31, 2021

Conversation

xoviat
Copy link
Contributor

@xoviat xoviat commented Jan 26, 2021

Also, use stock clangdev, llvmdev, and remove flang-meta package.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@xoviat
Copy link
Contributor Author

xoviat commented Jan 26, 2021

@conda-forge-admin Please rerender.

conda-forge-linter and others added 2 commits January 26, 2021 17:18
@xoviat xoviat closed this Jan 26, 2021
@xoviat xoviat reopened this Jan 26, 2021
@xoviat
Copy link
Contributor Author

xoviat commented Jan 26, 2021

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [57, 79]

For recipe:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@xoviat
Copy link
Contributor Author

xoviat commented Jan 26, 2021

@isuruf cmake appears to install to "build env" rather than "h env". I tried to fix it, but failed.

@isuruf
Copy link
Member

isuruf commented Jan 26, 2021

Can you revert to 6c280b5 ? That run failed because llvmdev 11 is not patched to produce a flang.exe.

@xoviat
Copy link
Contributor Author

xoviat commented Jan 26, 2021

@isuruf That's not correct. I reconfigured flang so that it doesn't require a patched clang or llvm. See https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=269696&view=logs&j=a70f640f-cc53-5cd3-6cdc-236a1aa90802&t=f5d15007-a01c-5ad8-c9ce-4d519d3b275f&l=107152, (scroll down to 107180).

That build failed because it copied the files to build_env

2021-01-26T19:54:26.4517925Z -- Install configuration: "Release"
2021-01-26T19:54:26.4529322Z -- Installing: D:/bld/flang-split_1611689514148/_build_env/Library/include/flang
2021-01-26T19:54:26.4537354Z -- Installing: D:/bld/flang-split_1611689514148/_build_env/Library/include/flang/ieee_arithmetic.mod
2021-01-26T19:54:26.4576860Z -- Installing: D:/bld/flang-split_1611689514148/_build_env/Library/include/flang/ieee_arithmetic_la.mod
2021-01-26T19:54:26.4614130Z -- Installing: D:/bld/flang-split_1611689514148/_build_env/Library/include/flang/ieee_exceptions.mod
2021-01-26T19:54:26.4640232Z -- Installing: D:/bld/flang-split_1611689514148/_build_env/Library/include/flang/ieee_exceptions_la.mod
2021-01-26T19:54:26.4666674Z -- Installing: D:/bld/flang-split_1611689514148/_build_env/Library/include/flang/ieee_features.mod
2021-01-26T19:54:26.4677048Z -- Installing: D:/bld/flang-split_1611689514148/_build_env/Library/include/flang/iso_c_binding.mod
2021-01-26T19:54:26.4693191Z -- Installing: D:/bld/flang-split_1611689514148/_build_env/Library/include/flang/iso_fortran_env.mod
2021-01-26T19:54:26.4703503Z -- Installing: D:/bld/flang-split_1611689514148/_build_env/Library/include/flang/omp_lib.mod
2021-01-26T19:54:26.4731586Z -- Installing: D:/bld/flang-split_1611689514148/_build_env/Library/include/flang/omp_lib_kinds.mod
2021-01-26T19:54:26.4739211Z -- Installing: D:/bld/flang-split_1611689514148/_build_env/Library/include/flang/__norm2.mod
2021-01-26T19:54:26.4757201Z -- Installing: D:/bld/flang-split_1611689514148/_build_env/Library/include/flang/__norm2_i8.mod
2021-01-26T19:54:26.4771664Z -- Installing: D:/bld/flang-split_1611689514148/_build_env/Library/include/flang/omp_lib.h
2021-01-26T19:54:26.4800056Z -- Installing: D:/bld/flang-split_1611689514148/_build_env/Library/lib/flangADT.lib
2021-01-26T19:54:26.4827723Z -- Installing: D:/bld/flang-split_1611689514148/_build_env/Library/lib/flangArgParser.lib
2021-01-26T19:54:26.4880884Z -- Installing: D:/bld/flang-split_1611689514148/_build_env/Library/lib/libpgmath.lib
2021-01-26T19:54:26.7155734Z -- Installing: D:/bld/flang-split_1611689514148/_build_env/Library/lib/pgmath.lib
2021-01-26T19:54:27.0009780Z -- Installing: D:/bld/flang-split_1611689514148/_build_env/Library/lib/ompstub.lib
2021-01-26T19:54:27.0030530Z -- Installing: D:/bld/flang-split_1611689514148/_build_env/Library/lib/libompstub.lib
2021-01-26T19:54:27.0058330Z -- Installing: D:/bld/flang-split_1611689514148/_build_env/Library/bin/libompstub.dll
2021-01-26T19:54:27.0087925Z -- Installing: D:/bld/flang-split_1611689514148/_build_env/Library/lib/flangrti.lib
2021-01-26T19:54:27.0142021Z -- Installing: D:/bld/flang-split_1611689514148/_build_env/Library/lib/libflangrti.lib
2021-01-26T19:54:27.0171739Z -- Installing: D:/bld/flang-split_1611689514148/_build_env/Library/bin/libflangrti.dll
2021-01-26T19:54:27.0215226Z -- Installing: D:/bld/flang-split_1611689514148/_build_env/Library/lib/flang.lib
2021-01-26T19:54:27.3065040Z -- Installing: D:/bld/flang-split_1611689514148/_build_env/Library/lib/libflang.lib
2021-01-26T19:54:27.3438161Z -- Installing: D:/bld/flang-split_1611689514148/_build_env/Library/bin/libflang.dll
2021-01-26T19:54:27.7056156Z -- Installing: D:/bld/flang-split_1611689514148/_build_env/Library/lib/flangmain.lib
2021-01-26T19:54:27.7099783Z -- Installing: D:/bld/flang-split_1611689514148/_build_env/Library/bin/flang.exe
2021-01-26T19:54:27.7507193Z -- Installing: D:/bld/flang-split_1611689514148/_build_env/Library/bin/flang1.exe
2021-01-26T19:54:27.9166422Z -- Installing: D:/bld/flang-split_1611689514148/_build_env/Library/bin/flang2.exe

we see that two files are copied here:

2021-01-26T19:54:28.3521007Z Resource usage statistics from bundling flang:
2021-01-26T19:54:28.3521541Z    Process count: 5
2021-01-26T19:54:28.3521912Z    CPU time: Sys=0:00:00.8, User=0:00:00.5
2021-01-26T19:54:28.3522334Z    Memory: 88.3M
2021-01-26T19:54:28.3522646Z    Disk usage: 499.3M
2021-01-26T19:54:28.3523031Z    Time elapsed: 0:00:07.2
2021-01-26T19:54:28.3523301Z 
2021-01-26T19:54:28.3523571Z 
2021-01-26T19:54:28.3736325Z number of files: 2
2021-01-26T19:54:28.3765465Z Fixing permissions

recipe/install_flang.bat Outdated Show resolved Hide resolved
@xoviat
Copy link
Contributor Author

xoviat commented Jan 27, 2021

Note: it shouldn't be too difficult to get linux working with this as well, but I don't have a linux box and I'm currently too lazy to install wsl.

@xoviat
Copy link
Contributor Author

xoviat commented Jan 27, 2021

@isuruf before you merge this, I have some minor fixes, so I'd like to update the commit. Let me know if you're okay with this first.

@xoviat
Copy link
Contributor Author

xoviat commented Jan 27, 2021

image
image

@xoviat
Copy link
Contributor Author

xoviat commented Jan 27, 2021

anything else?

@xoviat
Copy link
Contributor Author

xoviat commented Jan 27, 2021

Wait libflang needs pgmath as well, maybe

@xoviat
Copy link
Contributor Author

xoviat commented Jan 27, 2021

@isuruf This looks good.

@xoviat
Copy link
Contributor Author

xoviat commented Jan 27, 2021

@isuruf I went ahead an confirmed that this works on OpenBLAS with enhanced testing (OpenMathLib/OpenBLAS#3088).

@isuruf
Copy link
Member

isuruf commented Jan 27, 2021

Is flang.dll that this produce compatible with the older flang.dll?

@xoviat
Copy link
Contributor Author

xoviat commented Jan 27, 2021

I can say with complete certainty that the flang.dll that this produces is ABI-compatible with the DLL from the official flang project (if one were to be generated). The official flang project extracted some of the math functionality into a new "pgmath.dll" library. This is not a change that I made; I simply have as few changes as possible with the official flang project, while fixing any major bugs.

@xoviat
Copy link
Contributor Author

xoviat commented Jan 27, 2021

@xoviat
Copy link
Contributor Author

xoviat commented Jan 27, 2021

I think it would be nice to have a new flang though, because right now the clang version is stuck at 5, and flang is the only fortran compiler in conda-forge for windows.

@xoviat
Copy link
Contributor Author

xoviat commented Jan 30, 2021

@isuruf Is there anything else?

@isuruf isuruf merged commit 5ed618e into conda-forge:master Jan 31, 2021
@isuruf
Copy link
Member

isuruf commented Jan 31, 2021

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants