Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit flake8 #22

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Limit flake8 #22

merged 2 commits into from
Nov 29, 2022

Conversation

dopplershift
Copy link
Member

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

The new version breaks this plugin.
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@dopplershift dopplershift added the automerge Merge the PR when CI passes label Nov 29, 2022
@github-actions github-actions bot merged commit c640673 into conda-forge:main Nov 29, 2022
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@matthiasdiener
Copy link
Contributor

Would you be open to using zheller/flake8-quotes#111 as a patch here instead of limiting the flake8 version? If so, I'd be happy to create a PR.

@dopplershift
Copy link
Member Author

I was hoping that PR would get a quick review and merge for a new version.

Since the PR is small and looks like the correct migration, I'm open to merging it.

@matthiasdiener matthiasdiener mentioned this pull request Nov 29, 2022
5 tasks
@matthiasdiener
Copy link
Contributor

Since the PR is small and looks like the correct migration, I'm open to merging it.

I opened the PR as #23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants