Arch Migrator #58

regro-cf-autotick-bot · 2022-11-18T10:40:07Z

This feedstock is being rebuilt as part of the aarch64/ppc64le migration.

Feel free to merge the PR if CI is all green, but please don't close it
without reaching out the the ARM migrators first at @conda-forge/arm-arch.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

_{This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3495928881, please use this URL for debugging.}

…nda-forge-pinning 2022.11.18.09.29.52

conda-forge-linter · 2022-11-18T10:40:13Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham · 2023-01-04T22:09:52Z

@conda-forge-admin, please re-render

…nda-forge-pinning 2023.01.04.13.03.46

conda-forge-linter · 2023-01-04T22:20:02Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

conda-forge-linter · 2023-01-04T22:27:09Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham · 2023-01-04T22:27:31Z

@conda-forge-admin, please re-render

github-actions · 2023-01-04T22:30:18Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/faiss-split-feedstock/actions/runs/3842104858.

jakirkham · 2023-01-04T23:32:18Z

@conda-forge-admin, please re-render

bdice · 2023-01-04T23:44:34Z

recipe/build-pkg.sh

-    -B _build_python_avx2 \
-    faiss/python
-cmake --build _build_python_avx2 --target swigfaiss_avx2 -j $CPU_COUNT
+if [[ "${target_platform}" == *-64 ]]; then


Is this supposed to match win-64 and linux-64 but not linux-aarch64 or linux-ppc64le? What about osx-64? I saw a comment below, the linux & windows CI agents support AVX2 (OSX doesn't yet). I'd prefer to check explicitly for specific matching strings.

This isn't used on Windows. There are .bat build files for that.

AFAICT this was already building on macOS. So this doesn't change that.

All this does is exclude non-x86_64 targets.

jakirkham · 2023-01-04T23:55:14Z

cc @Ethyling

h-vetinari · 2023-01-05T00:40:07Z

@jakirkham, you might find some useful (if somewhat dated) commits for this in #45

jakirkham · 2023-01-05T02:01:26Z

Thanks Axel 🙏

Have looked through that PR and it looks like this includes similar changes. The approach differs slightly (though the differences are largely cosmetic)

jakirkham · 2023-01-05T09:27:42Z

@conda-forge-admin, please restart CI

(Travis CI is having some issues cloning the PR for some reason. Hoping this clears that out)

jakirkham · 2023-01-05T23:54:36Z

The CUDA builds are taking longer than the CI limits. Had briefly explored other ways to improve this (using Ninja), but ran into some bugs (likely due to the CMake config from FAISS).

As the other archs (CPU only) already build ok, have reverted to just the changes to build those for now. That way we can hopefully get those in sooner.

There will be another bot PR for the CUDA arch migrator. We can follow up on other changes needed for that one.

jakirkham · 2023-01-06T10:26:16Z

It looks like all the jobs passed except one Linux x86_64 CUDA job that ran into the CI time limit. Guessing this just gets close and in this one case went over (based on looking at other similar jobs).

If the changes here seem reasonable, would suggest we merge and then I can babysit CI on main tomorrow to get the packages out.

h-vetinari · 2023-01-06T12:39:41Z

If the changes here seem reasonable, would suggest we merge and then I can babysit CI on main tomorrow to get the packages out.

Yeah, that's what's unfortunately necessary on this feedstock. There were some specific CUDA builds that always timed out, which have consequently been skipped. It's a pity, with an hour or so more we'd be fine here. Or if we made some progress on archspec, we wouldn't have to compile the code twice for x86 to have fat binaries for sse/avx2...

jakirkham · 2023-01-06T18:45:13Z

Thanks Axel! 🙏

Yeah no worries.

Interesting about the archspec and repeated compilation point. Maybe this is an angle worth looking at further. Have there been existing attempts here?

h-vetinari · 2023-01-06T20:43:00Z

Interesting about the archspec and repeated compilation point. Maybe this is an angle worth looking at further. Have there been existing attempts here?

Have a look in #23 and the links therein. This is definitely worth pursuing, but conda-forge infra isn't ready yet, and I've given up pinging on the respective issue (which isn't on this feedstock).

jakirkham · 2023-01-06T22:42:22Z

Thanks Axel! 🙏

Will take a look. Think one of the issues was we lacked the kind of plugin infrastructure we would want to start customizing Conda in the ways we would like. This was very recently introduced late last year. Please see this blogpost.

It may be more doable in the future, but would require more work in the tooling as well before conda-forge would see direct benefits.

On a different note, only a couple builds failed. Restarted them somewhat recently.

Have also refreshed the macOS ARM builds to use the changes from here simplifying that PR ( #39 ).

In terms of CUDA arch builds, PR ( #62 ) was recently opened by the migrator.

regro-cf-autotick-bot added 2 commits November 18, 2022 10:37

migration: ArchRebuild

573a459

MNT: Re-rendered with conda-build 3.23.0, conda-smithy 3.21.3, and co…

d0ed46b

…nda-forge-pinning 2022.11.18.09.29.52

regro-cf-autotick-bot requested a review from h-vetinari as a code owner November 18, 2022 10:40

MNT: Re-rendered with conda-build 3.23.3, conda-smithy 3.22.1, and co…

1e67bc4

…nda-forge-pinning 2023.01.04.13.03.46

Use AVX2 on x86_64 architectures only

eb76b40

jakirkham force-pushed the bot-pr_arch_h4d93ba branch from 4bf398a to eb76b40 Compare January 4, 2023 22:27

jakirkham added 2 commits January 4, 2023 14:33

Constrain BLAS for testing on x86_64 only

193a5f9

Run generic package tests on other architectures

fe14caf

jakirkham force-pushed the bot-pr_arch_h4d93ba branch from 85e32f5 to fe14caf Compare January 4, 2023 22:46

Build AVX2 only on x86_64

0a30f14

bdice reviewed Jan 4, 2023

View reviewed changes

jakirkham changed the title ~~Arch Migrator~~ Arch Migrator w/CUDA Jan 4, 2023

conda-forge-linter closed this Jan 5, 2023

conda-forge-linter reopened this Jan 5, 2023

bdice mentioned this pull request Jan 5, 2023

Update builds for CUDA 11.8 and Python 3.10 rapidsai/raft#1120

Merged

Bump build/number to 3

6926c55

jakirkham force-pushed the bot-pr_arch_h4d93ba branch from 0f46165 to 6926c55 Compare January 5, 2023 23:44

jakirkham changed the title ~~Arch Migrator w/CUDA~~ Arch Migrator Jan 5, 2023

h-vetinari approved these changes Jan 6, 2023

View reviewed changes

h-vetinari merged commit 1c7f899 into conda-forge:main Jan 6, 2023

regro-cf-autotick-bot deleted the bot-pr_arch_h4d93ba branch January 6, 2023 13:20

jakirkham mentioned this pull request Jan 6, 2023

ARM OSX Migrator #39

Merged

jakirkham mentioned this pull request Nov 28, 2023

Support ppc64le cuda #6

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Arch Migrator #58

Arch Migrator #58

regro-cf-autotick-bot commented Nov 18, 2022 •

edited by jakirkham

Loading

conda-forge-linter commented Nov 18, 2022

jakirkham commented Jan 4, 2023

conda-forge-linter commented Jan 4, 2023

conda-forge-linter commented Jan 4, 2023

jakirkham commented Jan 4, 2023

github-actions bot commented Jan 4, 2023

jakirkham commented Jan 4, 2023

bdice Jan 4, 2023

jakirkham Jan 4, 2023

jakirkham commented Jan 4, 2023

h-vetinari commented Jan 5, 2023

jakirkham commented Jan 5, 2023

jakirkham commented Jan 5, 2023

jakirkham commented Jan 5, 2023

jakirkham commented Jan 6, 2023

h-vetinari commented Jan 6, 2023

jakirkham commented Jan 6, 2023

h-vetinari commented Jan 6, 2023

jakirkham commented Jan 6, 2023

Arch Migrator #58

Arch Migrator #58

Conversation

regro-cf-autotick-bot commented Nov 18, 2022 • edited by jakirkham Loading

conda-forge-linter commented Nov 18, 2022

jakirkham commented Jan 4, 2023

conda-forge-linter commented Jan 4, 2023

conda-forge-linter commented Jan 4, 2023

jakirkham commented Jan 4, 2023

github-actions bot commented Jan 4, 2023

jakirkham commented Jan 4, 2023

bdice Jan 4, 2023

Choose a reason for hiding this comment

jakirkham Jan 4, 2023

Choose a reason for hiding this comment

jakirkham commented Jan 4, 2023

h-vetinari commented Jan 5, 2023

jakirkham commented Jan 5, 2023

jakirkham commented Jan 5, 2023

jakirkham commented Jan 5, 2023

jakirkham commented Jan 6, 2023

h-vetinari commented Jan 6, 2023

jakirkham commented Jan 6, 2023

h-vetinari commented Jan 6, 2023

jakirkham commented Jan 6, 2023

regro-cf-autotick-bot commented Nov 18, 2022 •

edited by jakirkham

Loading