Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove caching of compilers #238

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Remove caching of compilers #238

merged 1 commit into from
Jul 21, 2023

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Jul 20, 2023

These caches don't work usually because the version downloaded here is the newest while the feedstocks don't use the latest.

cc @h-vetinari

@jakirkham
Copy link
Member

Seems reasonable. These were added as a convenience in the past. They don't actually need to be there (nothing in the images use them)

@h-vetinari
Copy link
Member

Makes sense 👍

@hmaarrfk
Copy link
Contributor

why not cache the default versions? isn't that "better"? we could also update the default compiler right?

@jakirkham
Copy link
Member

Think the challenge we are running into is some CI jobs are running out of memory (particularly CUDA cross-compiled jobs). So cutting out these extra bits would help remove pressure for those jobs

Given feedstocks can (and sometimes do) deviate from the compiler version in conda-forge-pinning, we probably can't generally cache the right compiler version in all cases. As a result, dropping the cached compilers seem reasonable

Would add that when we added these it was before .conda and may have preceded CDN. So it was fairly helpful then. Now it doesn't really feel necessary

@hmaarrfk
Copy link
Contributor

ok understood about the space

@jakirkham
Copy link
Member

Hmm...seems that automerge label isn't doing anything

@jakirkham jakirkham merged commit 7147486 into conda-forge:main Jul 21, 2023
@jakirkham
Copy link
Member

Thanks Isuru for the PR and everyone for the reviews! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants