-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docker image for ppc64le and CUDA #113
Conversation
This is great! Thanks! |
Yes, sadly.... |
So this contains the If you are referring to |
@jjhelmus, do you know if it would be possible to get some updated |
I work on IBM's WML-CE and we have both https://public.dhe.ibm.com/ibmdl/export/pub/software/server/ibm-ai/conda/#/ The -dev package has nvcc and the lot. We moved to conda just this year so we started with cuda10.1 and will continue from there. Older CUDA versions have various problems on ppc64le anyway - some better than others. Packages in WML-CE are free to use and there is a auto-acceptable license that comes along with. |
Yeah we can look into this as well. Initially our thought was it would be nice to use the Docker image to simplify the install and distribution process. They've also worked reasonably well for our use cases. Hopefully we can move to Docker multi-arch images in the future to improve organization and maintenance here. ( #102 ) |
At this time we are not building GPU packages for the |
Completely understand Anaconda not building out the stack if it doesn't make sense. However would it be possible to get an updated |
Have raised issue ( AnacondaRecipes/cudatoolkit-feedstock#4 ) about |
@kkraus14 mentioned that they were asking NVIDIA internally about distributing these through conda-forge. Any updates? |
Nothing yet. |
Borrowing from the ppc64le image, create an image that also supports CUDA builds.
d8d8ce9
to
2ca59df
Compare
2ca59df
to
2aba024
Compare
@conda-forge/core, this is ready for review. The hold up was caching of |
I don’t understand how this can be useful without that |
@jakirkham, this is useful for packages using only the driver API. They don't need About licensing, we are not distributing |
If we don’t have The Docker image is a special case in NVIDIA’s licensing that allows the distribution of the CUDA toolkit in the image. It in fact already ships with everything in the As I’m taking time off atm, I’d very much appreciate pushing pause here. This has been waiting for a while. Waiting until next week to discuss this should be fine. |
Okay, let's not merge this for a week, but we can keep the discussion going. |
Just to be clear I don’t think this should be merged without addressing the things mentioned above. |
@jakirkham, this image is useful for packages using CUDA driver API which doesn't need |
ping |
@jakirkham and @kkraus14 says that NVIDIA legal team said that this docker image is okay.
Thanks @isuruf! Adding a comment seems sufficient for getting this point across. If we find people are still confused, we can figure out more appropriate messaging then. LGTM |
Looks to be as good as we can make it at the moment. Thanks @isuruf |
Thanks @jakirkham for the work and everybody for the review. |
@@ -0,0 +1,80 @@ | |||
# Note that this image doesn't cache cudatoolkit as it is not packaged by defaults. | |||
# This docker image is meant for packages using CUDA driver and not for packages | |||
# using the CUDA runtime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have also raised issue ( #141 ) about this so we can track this need/redirect people there.
This adds a Docker image that is an amalgamation of the CUDA Docker image and the ppc64le images to enable building ppc64le packages that have CUDA portions enabled as well.
cc @jayfurmanek
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)