add CUDA support #76

kuepe-sl · 2023-12-13T16:30:18Z

Checklist

Used a personal fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
Ensured the license file is being packaged.

Resolves #54

conda-forge-webservices · 2023-12-13T16:30:26Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

kuepe-sl · 2023-12-14T13:30:21Z

Windows and Linux builds work fine.

The OSX build fails while detecting the C compiler for some reason:

Building wheels for collected packages: dlib
  Created temporary directory: /private/tmp/pip-wheel-7y2efidk
  Destination directory: /private/tmp/pip-wheel-7y2efidk
  Building wheel for dlib (pyproject.toml): started
  Running command Building wheel for dlib (pyproject.toml)
  running bdist_wheel
  running build
  running build_ext
  Building extension for Python 3.10.13 | packaged by conda-forge | (main, Oct 26 2023, 18:09:20) [Clang 16.0.6 ]
  Invoking CMake setup: 'cmake /Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/work/tools/python -DCMAKE_LIBRARY_OUTPUT_DIRECTORY=/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/work/build/lib.macosx-10.9-x86_64-cpython-310 -DPYTHON_EXECUTABLE=/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/bin/python -DJPEG_INCLUDE_DIR=/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/include -DPNG_PNG_INCLUDE_DIR=/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/include -DPNG_INCLUDE_DIR=/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/include -Dsqlite_path=/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/include -DBUILD_SHARED_LIBS=ON -DDLIB_IN_PROJECT_BUILD=ON -DCMAKE_AR=/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/_build_env/bin/x86_64-apple-darwin13.4.0-ar -DCMAKE_CXX_COMPILER_AR=/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/_build_env/bin/x86_64-apple-darwin13.4.0-ar -DCMAKE_C_COMPILER_AR=/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/_build_env/bin/x86_64-apple-darwin13.4.0-ar -DCMAKE_RANLIB=/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/_build_env/bin/x86_64-apple-darwin13.4.0-ranlib -DCMAKE_CXX_COMPILER_RANLIB=/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/_build_env/bin/x86_64-apple-darwin13.4.0-ranlib -DCMAKE_C_COMPILER_RANLIB=/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/_build_env/bin/x86_64-apple-darwin13.4.0-ranlib -DCMAKE_LINKER=/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/_build_env/bin/x86_64-apple-darwin13.4.0-ld -DCMAKE_STRIP=/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/_build_env/bin/x86_64-apple-darwin13.4.0-strip -DCMAKE_INSTALL_NAME_TOOL=/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/_build_env/bin/x86_64-apple-darwin13.4.0-install_name_tool -DCMAKE_LIBTOOL=/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/_build_env/bin/x86_64-apple-darwin13.4.0-libtool -DCMAKE_OSX_DEPLOYMENT_TARGET=10.9 -DCMAKE_BUILD_TYPE=Release -DCMAKE_OSX_SYSROOT=/Applications/Xcode_13.2.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_FIND_APPBUNDLE=LAST -DCMAKE_INSTALL_PREFIX=/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol -DCMAKE_INSTALL_LIBDIR=lib -DCMAKE_PROGRAM_PATH=/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/_build_env/bin;/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/bin -DCMAKE_BUILD_TYPE=Release'
  -- The C compiler identification is Clang 16.0.6
  -- The CXX compiler identification is Clang 16.0.6
  -- Detecting C compiler ABI info
  Traceback (most recent call last):
    File "/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
      main()
    File "/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
      json_out['return_val'] = hook(**hook_input['kwargs'])
    File "/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 251, in build_wheel
      return _build_backend().build_wheel(wheel_directory, config_settings,
    File "/private/tmp/pip-build-env-tfka1ozk/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 404, in build_wheel
      return self._build_with_temp_dir(
    File "/private/tmp/pip-build-env-tfka1ozk/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 389, in _build_with_temp_dir
      self.run_setup()
    File "/private/tmp/pip-build-env-tfka1ozk/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 311, in run_setup
      exec(code, locals())
    File "<string>", line 217, in <module>
    File "/private/tmp/pip-build-env-tfka1ozk/overlay/lib/python3.10/site-packages/setuptools/__init__.py", line 103, in setup
      return distutils.core.setup(**attrs)
    File "/private/tmp/pip-build-env-tfka1ozk/overlay/lib/python3.10/site-packages/setuptools/_distutils/core.py", line 185, in setup
      return run_commands(dist)
    File "/private/tmp/pip-build-env-tfka1ozk/overlay/lib/python3.10/site-packages/setuptools/_distutils/core.py", line 201, in run_commands
      dist.run_commands()
    File "/private/tmp/pip-build-env-tfka1ozk/overlay/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 969, in run_commands
      self.run_command(cmd)
    File "/private/tmp/pip-build-env-tfka1ozk/overlay/lib/python3.10/site-packages/setuptools/dist.py", line 963, in run_command
      super().run_command(command)
    File "/private/tmp/pip-build-env-tfka1ozk/overlay/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 988, in run_command
      cmd_obj.run()
    File "/private/tmp/pip-build-env-tfka1ozk/overlay/lib/python3.10/site-packages/wheel/bdist_wheel.py", line 368, in run
      self.run_command("build")
    File "/private/tmp/pip-build-env-tfka1ozk/overlay/lib/python3.10/site-packages/setuptools/_distutils/cmd.py", line 318, in run_command
      self.distribution.run_command(command)
    File "/private/tmp/pip-build-env-tfka1ozk/overlay/lib/python3.10/site-packages/setuptools/dist.py", line 963, in run_command
      super().run_command(command)
    File "/private/tmp/pip-build-env-tfka1ozk/overlay/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 988, in run_command
      cmd_obj.run()
    File "/private/tmp/pip-build-env-tfka1ozk/overlay/lib/python3.10/site-packages/setuptools/_distutils/command/build.py", line 131, in run
      self.run_command(cmd_name)
    File "/private/tmp/pip-build-env-tfka1ozk/overlay/lib/python3.10/site-packages/setuptools/_distutils/cmd.py", line 318, in run_command
      self.distribution.run_command(command)
    File "/private/tmp/pip-build-env-tfka1ozk/overlay/lib/python3.10/site-packages/setuptools/dist.py", line 963, in run_command
      super().run_command(command)
    File "/private/tmp/pip-build-env-tfka1ozk/overlay/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 988, in run_command
      cmd_obj.run()
    File "<string>", line 130, in run
    File "<string>", line 166, in build_extension
    File "/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib/python3.10/subprocess.py", line 369, in check_call
      raise CalledProcessError(retcode, cmd)
  subprocess.CalledProcessError: Command '['cmake', '/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/work/tools/python', '-DCMAKE_LIBRARY_OUTPUT_DIRECTORY=/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/work/build/lib.macosx-10.9-x86_64-cpython-310', '-DPYTHON_EXECUTABLE=/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/bin/python', '-DJPEG_INCLUDE_DIR=/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/include', '-DPNG_PNG_INCLUDE_DIR=/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/include', '-DPNG_INCLUDE_DIR=/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/include', '-Dsqlite_path=/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/include', '-DBUILD_SHARED_LIBS=ON', '-DDLIB_IN_PROJECT_BUILD=ON', '-DCMAKE_AR=/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/_build_env/bin/x86_64-apple-darwin13.4.0-ar', '-DCMAKE_CXX_COMPILER_AR=/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/_build_env/bin/x86_64-apple-darwin13.4.0-ar', '-DCMAKE_C_COMPILER_AR=/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/_build_env/bin/x86_64-apple-darwin13.4.0-ar', '-DCMAKE_RANLIB=/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/_build_env/bin/x86_64-apple-darwin13.4.0-ranlib', '-DCMAKE_CXX_COMPILER_RANLIB=/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/_build_env/bin/x86_64-apple-darwin13.4.0-ranlib', '-DCMAKE_C_COMPILER_RANLIB=/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/_build_env/bin/x86_64-apple-darwin13.4.0-ranlib', '-DCMAKE_LINKER=/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/_build_env/bin/x86_64-apple-darwin13.4.0-ld', '-DCMAKE_STRIP=/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/_build_env/bin/x86_64-apple-darwin13.4.0-strip', '-DCMAKE_INSTALL_NAME_TOOL=/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/_build_env/bin/x86_64-apple-darwin13.4.0-install_name_tool', '-DCMAKE_LIBTOOL=/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/_build_env/bin/x86_64-apple-darwin13.4.0-libtool', '-DCMAKE_OSX_DEPLOYMENT_TARGET=10.9', '-DCMAKE_BUILD_TYPE=Release', '-DCMAKE_OSX_SYSROOT=/Applications/Xcode_13.2.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk', '-DCMAKE_FIND_FRAMEWORK=LAST', '-DCMAKE_FIND_APPBUNDLE=LAST', '-DCMAKE_INSTALL_PREFIX=/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol', '-DCMAKE_INSTALL_LIBDIR=lib', '-DCMAKE_PROGRAM_PATH=/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/_build_env/bin;/Users/runner/miniforge3/conda-bld/dlib-split_1702556472393/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/bin', '-DCMAKE_BUILD_TYPE=Release']' returned non-zero exit status 245.
  error: subprocess-exited-with-error

I didn't touch the OSX parts though and the OSX configuration files are unchanged, except that a cuda_compiler_version entry got added. So I don't know what to do here.

Any suggestions?

Tobias-Fischer · 2023-12-14T22:24:45Z

For some reason, pip installs cmake, setuptools and wheel; I reckon this causes trouble. This was not the case in the latest build on main.

Processing /Users/runner/miniforge3/conda-bld/dlib-split_1702556298338/work
  Added file:///Users/runner/miniforge3/conda-bld/dlib-split_1702556298338/work to build tracker '/private/tmp/pip-build-tracker-l2ywhwk3'
  Created temporary directory: /private/tmp/pip-build-env-b73i7hms
  Installing build dependencies: started
  Running command pip subprocess to install build dependencies
  Using pip 23.3.1 from /Users/runner/miniforge3/conda-bld/dlib-split_1702556298338/_build_env/lib/python3.10/site-packages/pip (python 3.10)
  Collecting setuptools
    Obtaining dependency information for setuptools from https://files.pythonhosted.org/packages/bb/e1/ed2dd0850446b8697ad28d118df885ad04140c64ace06c4bd559f7c8a94f/setuptools-69.0.2-py3-none-any.whl.metadata
    Downloading setuptools-69.0.2-py3-none-any.whl.metadata (6.3 kB)
  Collecting wheel
    Obtaining dependency information for wheel from https://files.pythonhosted.org/packages/c7/c3/55076fc728723ef927521abaa1955213d094933dc36d4a2008d5101e1af5/wheel-0.42.0-py3-none-any.whl.metadata
    Downloading wheel-0.42.0-py3-none-any.whl.metadata (2.2 kB)
  Collecting cmake
    Obtaining dependency information for cmake from https://files.pythonhosted.org/packages/4a/3f/21bd0a2320f3cb83d5a6485b1b258a405a24a92a34c036612c308f340d53/cmake-3.28.0-py2.py3-none-macosx_10_10_universal2.macosx_10_10_x86_64.macosx_11_0_arm64.macosx_11_0_universal2.whl.metadata
    Downloading cmake-3.28.0-py2.py3-none-macosx_10_10_universal2.macosx_10_10_x86_64.macosx_11_0_arm64.macosx_11_0_universal2.whl.metadata (6.3 kB)
  Downloading setuptools-69.0.2-py3-none-any.whl (819 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 819.5/819.5 kB 7.9 MB/s eta 0:00:00
  Downloading wheel-0.42.0-py3-none-any.whl (65 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 65.4/65.4 kB 4.8 MB/s eta 0:00:00
  Downloading cmake-3.28.0-py2.py3-none-macosx_10_10_universal2.macosx_10_10_x86_64.macosx_11_0_arm64.macosx_11_0_universal2.whl (48.5 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 48.5/48.5 MB 29.7 MB/s eta 0:00:00
  Installing collected packages: cmake, wheel, setuptools
    Creating /private/tmp/pip-build-env-b73i7hms/overlay/bin
    changing mode of /private/tmp/pip-build-env-b73i7hms/overlay/bin/cmake to 755
    changing mode of /private/tmp/pip-build-env-b73i7hms/overlay/bin/cpack to 755
    changing mode of /private/tmp/pip-build-env-b73i7hms/overlay/bin/ctest to 755
    changing mode of /private/tmp/pip-build-env-b73i7hms/overlay/bin/wheel to 755
  Successfully installed cmake-3.28.0 setuptools-69.0.2 wheel-0.42.0

kuepe-sl · 2023-12-15T08:06:30Z

I tried to explicitly specify wheel in the host section to prevent pip from installing it, but this doesn't seem to work.

  environment location: /Users/runner/miniforge3/conda-bld/dlib-split_1702625369571/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol

The following NEW packages will be INSTALLED:

	[...]
    setuptools:      68.2.2-pyhd8ed1ab_0        conda-forge
	[...]
    wheel:           0.42.0-pyhd8ed1ab_0        conda-forge
	[...]


  environment location: /Users/runner/miniforge3/conda-bld/dlib-split_1702625369571/_build_env

The following NEW packages will be INSTALLED:

	[...]
    cmake:               3.28.1-h7c85d92_0         conda-forge
	[...]

Processing /Users/runner/miniforge3/conda-bld/dlib-split_1702625369571/work
  Added file:///Users/runner/miniforge3/conda-bld/dlib-split_1702625369571/work to build tracker '/private/tmp/pip-build-tracker-8q5_4_vc'
  Created temporary directory: /private/tmp/pip-build-env-rig4w7qd
  Installing build dependencies: started
  Running command pip subprocess to install build dependencies
  Using pip 23.3.1 from /Users/runner/miniforge3/conda-bld/dlib-split_1702625369571/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib/python3.10/site-packages/pip (python 3.10)
  Collecting setuptools
    Obtaining dependency information for setuptools from https://files.pythonhosted.org/packages/bb/e1/ed2dd0850446b8697ad28d118df885ad04140c64ace06c4bd559f7c8a94f/setuptools-69.0.2-py3-none-any.whl.metadata
    Downloading setuptools-69.0.2-py3-none-any.whl.metadata (6.3 kB)
  Collecting wheel
    Obtaining dependency information for wheel from https://files.pythonhosted.org/packages/c7/c3/55076fc728723ef927521abaa1955213d094933dc36d4a2008d5101e1af5/wheel-0.42.0-py3-none-any.whl.metadata
    Downloading wheel-0.42.0-py3-none-any.whl.metadata (2.2 kB)
  Collecting cmake
    Obtaining dependency information for cmake from https://files.pythonhosted.org/packages/4a/3f/21bd0a2320f3cb83d5a6485b1b258a405a24a92a34c036612c308f340d53/cmake-3.28.0-py2.py3-none-macosx_10_10_universal2.macosx_10_10_x86_64.macosx_11_0_arm64.macosx_11_0_universal2.whl.metadata
    Downloading cmake-3.28.0-py2.py3-none-macosx_10_10_universal2.macosx_10_10_x86_64.macosx_11_0_arm64.macosx_11_0_universal2.whl.metadata (6.3 kB)
  Downloading setuptools-69.0.2-py3-none-any.whl (819 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 819.5/819.5 kB 6.1 MB/s eta 0:00:00
  Downloading wheel-0.42.0-py3-none-any.whl (65 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 65.4/65.4 kB 5.6 MB/s eta 0:00:00
  Downloading cmake-3.28.0-py2.py3-none-macosx_10_10_universal2.macosx_10_10_x86_64.macosx_11_0_arm64.macosx_11_0_universal2.whl (48.5 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 48.5/48.5 MB 26.5 MB/s eta 0:00:00
  Installing collected packages: cmake, wheel, setuptools

pip install is already called with --no-deps.

This fixes the OSX build.

…nda-forge-pinning 2023.12.14.20.48.22

kuepe-sl · 2023-12-15T10:20:15Z

I'm not sure if the issue is related to conda/conda-build#3993 or if it is caused by something else.

I modified builder.py to explicitly set all the pip options that Conda Build sets as well and this fixes the issue.

Tobias-Fischer · 2023-12-15T10:33:42Z

Nice work! Is there any way to check whether cuda support is enabled in the test section to avoid future regression?

Tobias-Fischer · 2023-12-15T10:35:31Z

We should also use track features to prefer the cuda builds (or alternatively increase the build number for cuda builds by 100

Tobias-Fischer · 2023-12-15T10:37:11Z

And finally, totally optional, you might want to consider manually adding cuda 11.8 and 12 migrations

kuepe-sl · 2023-12-15T10:52:26Z

I based most of the modification on the recipe of tensorflow:
https://github.com/conda-forge/tensorflow-feedstock/blob/main/recipe/meta.yaml
Neither that one nor detectron2-feedstock (from the "CUDA support" issue) uses track features, so I didn't add those here either.

It looks like pytorch has them? https://github.com/conda-forge/pytorch-cpu-feedstock/blob/main/recipe/meta.yaml

Neither of the recipes has CUDA 11.8/CUDA 12 support, so I'd prefer to add the migrator later.

Neither does check for GPU support in the tests. I don't know if checking for GPU support is even possible in the CI.

kuepe-sl · 2023-12-15T11:03:50Z

If you want track features to be used, can you show me a recipe that does them in the way that is state-of-the-art on Conda Forge?

Tobias-Fischer · 2023-12-17T23:53:02Z

@conda-forge-admin, please rerender

…nda-forge-pinning 2023.12.17.14.24.54

Tobias-Fischer · 2023-12-18T01:31:47Z

@conda-forge-admin, please rerender

…nda-forge-pinning 2023.12.17.14.24.54

Tobias-Fischer · 2023-12-18T02:15:25Z

@conda-forge-admin, please rerender

…nda-forge-pinning 2023.12.17.14.24.54

Tobias-Fischer · 2023-12-18T02:18:47Z

I've added the track_features to down-weigh CPU builds, and added the CUDA11.8 migration. CUDA12.0 is too tricky for now, there is no upstream support. Thanks again @kuepe-sl

github-actions · 2023-12-18T03:07:27Z

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

linter: passed
azure: passed

Thus the PR was passing and merged! Have a great day!

kuepe-sl · 2023-12-18T13:39:17Z

Thanks for merging and having a look. 🙂

add CUDA support

4a4d6c9

kuepe-sl requested review from Tobias-Fischer, aldanor and patricksnape as code owners December 13, 2023 16:30

kuepe-sl force-pushed the cuda-support branch from c5d4f79 to 5a3fddd Compare December 14, 2023 11:16

fix Linux build

f299a8d

kuepe-sl force-pushed the cuda-support branch from d1c8bcb to 6bb6a49 Compare December 15, 2023 07:22

kuepe-sl added 2 commits December 15, 2023 09:32

don't install build deps via pip

2404a6a

This fixes the OSX build.

MNT: Re-rendered with conda-build 3.28.1, conda-smithy 3.30.1, and co…

526bfab

…nda-forge-pinning 2023.12.14.20.48.22

kuepe-sl force-pushed the cuda-support branch from 6bb6a49 to 526bfab Compare December 15, 2023 08:35

Tobias-Fischer added 2 commits December 18, 2023 09:36

Add track_features to down-weigh cpu implementation

2df4765

Create cuda118.yaml

b5eb036

MNT: Re-rendered with conda-build 3.27.0, conda-smithy 3.30.1, and co…

c8d364d

…nda-forge-pinning 2023.12.17.14.24.54

Tobias-Fischer added automerge Merge the PR when CI passes and removed automerge Merge the PR when CI passes labels Dec 17, 2023

Create cuda120.yaml

13a1a65

conda-forge-webservices[bot] and others added 2 commits December 18, 2023 01:34

MNT: Re-rendered with conda-build 3.27.0, conda-smithy 3.30.1, and co…

1a0d7e8

…nda-forge-pinning 2023.12.17.14.24.54

cublas for cuda12

9e324b3

Tobias-Fischer added 2 commits December 18, 2023 11:53

More cuda12 stuff

4e031c5

cuda 12.0 too tricky for now

65f4bc1

MNT: Re-rendered with conda-build 3.27.0, conda-smithy 3.30.1, and co…

59d4c3a

…nda-forge-pinning 2023.12.17.14.24.54

Tobias-Fischer added the automerge Merge the PR when CI passes label Dec 18, 2023

github-actions bot merged commit c992e07 into conda-forge:main Dec 18, 2023
49 checks passed

kuepe-sl deleted the cuda-support branch December 18, 2023 13:39

jakirkham mentioned this pull request Jan 6, 2024

Rebuild for CUDA 11.8 w/arch support #78

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add CUDA support #76

add CUDA support #76

kuepe-sl commented Dec 13, 2023

conda-forge-webservices bot commented Dec 13, 2023

kuepe-sl commented Dec 14, 2023

Tobias-Fischer commented Dec 14, 2023 •

edited

Loading

kuepe-sl commented Dec 15, 2023

kuepe-sl commented Dec 15, 2023

Tobias-Fischer commented Dec 15, 2023

Tobias-Fischer commented Dec 15, 2023 •

edited

Loading

Tobias-Fischer commented Dec 15, 2023

kuepe-sl commented Dec 15, 2023

kuepe-sl commented Dec 15, 2023

Tobias-Fischer commented Dec 17, 2023

Tobias-Fischer commented Dec 18, 2023

Tobias-Fischer commented Dec 18, 2023

Tobias-Fischer commented Dec 18, 2023

github-actions bot commented Dec 18, 2023

kuepe-sl commented Dec 18, 2023

add CUDA support #76

add CUDA support #76

Conversation

kuepe-sl commented Dec 13, 2023

conda-forge-webservices bot commented Dec 13, 2023

kuepe-sl commented Dec 14, 2023

Tobias-Fischer commented Dec 14, 2023 • edited Loading

kuepe-sl commented Dec 15, 2023

kuepe-sl commented Dec 15, 2023

Tobias-Fischer commented Dec 15, 2023

Tobias-Fischer commented Dec 15, 2023 • edited Loading

Tobias-Fischer commented Dec 15, 2023

kuepe-sl commented Dec 15, 2023

kuepe-sl commented Dec 15, 2023

Tobias-Fischer commented Dec 17, 2023

Tobias-Fischer commented Dec 18, 2023

Tobias-Fischer commented Dec 18, 2023

Tobias-Fischer commented Dec 18, 2023

github-actions bot commented Dec 18, 2023

kuepe-sl commented Dec 18, 2023

Tobias-Fischer commented Dec 14, 2023 •

edited

Loading

Tobias-Fischer commented Dec 15, 2023 •

edited

Loading