Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch arm64 and ppc64 builds to use Azure #5

Merged
merged 7 commits into from
Nov 3, 2021

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Nov 3, 2021

For some reason the arm64 and ppc64 build were not triggered after merging of #3 and #4, so I bumped the build number to make sure they are triggered.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@github-actions
Copy link

github-actions bot commented Nov 3, 2021

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

@traversaro
Copy link
Contributor Author

Actually the problem is conda-forge/status#122 .

@traversaro
Copy link
Contributor Author

Actually the problem is conda-forge/status#122 .

I guess we can simple switch to azure also for arm64 and ppc64 builds.

@traversaro traversaro changed the title Bump build number to 1 Switch arm64 and ppc64 builds to use Azure Nov 3, 2021
@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@traversaro
Copy link
Contributor Author

The emulated builds on arm64 and ppc64 take a lot of time (most of it spent in the configure script), but given that releases of diffutils are not this frequent I think it is reasonable compromise. @conda-forge/diffutils let me know if you have any objection, otherwise I think I can merge in one day.

@isuruf
Copy link
Member

isuruf commented Nov 3, 2021

You can also do cross compiling by using conda-forge/status#122 (comment)

@traversaro
Copy link
Contributor Author

traversaro commented Nov 3, 2021

You can also do cross compiling by using conda-forge/status#122 (comment)

Cool, I was not aware of this, thanks. I will try this as in any case there are no tests in this package.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@traversaro
Copy link
Contributor Author

And thanks for the fix @isuruf!

@traversaro
Copy link
Contributor Author

Thanks to cross-compiling, the build time on arm64/ppc64 is reduced to ~5 minutes.

@traversaro
Copy link
Contributor Author

I will try this as in any case there are no tests in this package.

Actually it seems that simple tests are there:

. However, it seems that are executed anyhow, not sure how.

@isuruf
Copy link
Member

isuruf commented Nov 3, 2021

However, it seems that are executed anyhow, not sure how.

Using QEMU

@traversaro
Copy link
Contributor Author

traversaro commented Nov 3, 2021

However, it seems that are executed anyhow, not sure how.

Using QEMU

Great, then as long as the build system supports it, using cross-compiling seems to be always a better idea w.r.t. to emulation, as you still run tests while running a faster compilation. Thanks!

@traversaro
Copy link
Contributor Author

However, it seems that are executed anyhow, not sure how.

Using QEMU

Great, then as long as the build system supports it, using cross-compiling seems to be always a better idea w.r.t. to emulation, as you still run tests while running a faster compilation.

Actually this is not completly true, as for some build systems (for example in C++/CMake) the tests normally need to run as part of the build step, and so they can't run if you are cross-compiling.

@traversaro traversaro merged commit 053dea4 into conda-forge:master Nov 3, 2021
@traversaro traversaro deleted the retrigger_arm branch November 3, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants