Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bot-automerge] deltalake v0.19.0 #45

Merged
merged 5 commits into from
Oct 4, 2024

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: disabled to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by grayskull shows a discrepancy between it and the the package's stated requirements in the meta.yaml.

Packages found by grayskull but not in the meta.yaml:

  • python >=3.8
  • python >=3.8
  • pyarrow >=16

Packages found in the meta.yaml but not found by grayskull:

  • python
  • xz
  • python
  • pyarrow >=8
  • pyarrow-hotfix

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/10419861712 - please use this URL for debugging.

@conda-forge-webservices
Copy link
Contributor

conda-forge-webservices bot commented Aug 16, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: failed

Thus the PR was not passing and not merged.

@charlesbluca
Copy link
Member

@conda-forge-admin , please re-render

Copy link
Contributor

github-actions bot commented Oct 3, 2024

Hi! This is the friendly conda-forge automerge bot!

It appears that not all commits to this PR were made by the bot. Thus this PR is not being automatically merged. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@jakirkham
Copy link
Member

On macOS, it looks like the tests pass, but pip check fails. Here is a snippet from one CI job:

===== testing package: deltalake-0.19.0-py312h16aec2d_0 =====
running run_test.py
PASSED: run_tests.py
===== deltalake-0.19.0-py312h16aec2d_0 OK =====
+ pip check
deltalake 0.19.0 is not supported on this platform

The release notes don't indicate macOS was dropped (just some CI changes)

Not sure why we are seeing this

@jakirkham
Copy link
Member

Thanks Dave! 🙏

Was wondering if there was a pip bug. Looks like this is the relevant upstream issue: pypa/pip#12884

@dhirschfeld
Copy link
Member

Yeah, was going to xlink that if it turned out to be the case - since osx has passed it looks like that was the issue.

@dhirschfeld
Copy link
Member

I guess this isn't a permanent fix, but I'm not sure what the right fix is. It seems like conda-build is producing pip metadata which fails the new stricter checks?

Copy link
Member

@dhirschfeld dhirschfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jakirkham
Copy link
Member

Well the build is driven by pip

script: {{ PYTHON }} -m pip install . -vv

So it could be pip is producing metadata it doesn't like

Though maturin is doing the building. So the issue could be there

- maturin >=1,<2

Or it could be some deltalake configuration issue

Anyways digging into that intersection may yield more actionable clues

@dhirschfeld
Copy link
Member

Any objection to merging with the pin and investigating further as time allows?

@jakirkham
Copy link
Member

Not from me. Though I'm not a maintainer here

Would suggest raising a feedstock issue for follow up on the pip check/wheel metadata points we have uncovered. We can collect new learnings there

@dhirschfeld dhirschfeld merged commit c5e2106 into conda-forge:main Oct 4, 2024
22 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 0.19.0_h01b185 branch October 4, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants